logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattsic...@apache.org
Subject svn commit: r1586431 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
Date Thu, 10 Apr 2014 19:22:48 GMT
Author: mattsicker
Date: Thu Apr 10 19:22:48 2014
New Revision: 1586431

URL: http://svn.apache.org/r1586431
Log:
Slight simplification by abusing removeAll.

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java?rev=1586431&r1=1586430&r2=1586431&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
(original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
Thu Apr 10 19:22:48 2014
@@ -830,10 +830,8 @@ public abstract class AbstractConfigurat
         checkForRemainingAttributes(node);
 
         if (!type.isDeferChildren() && used.size() != children.size()) {
+            children.removeAll(used);
             for (final Node child : children) {
-                if (used.contains(child)) {
-                    continue;
-                }
                 final String nodeType = node.getType().getElementName();
                 final String start = nodeType.equals(node.getName()) ? node.getName() : nodeType
+ ' ' + node.getName();
                 LOGGER.error("{} has no parameter that matches element {}", start, child.getName());



Mime
View raw message