logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <mattsic...@apache.org>
Subject Re: svn commit: r1583172 - /logging/log4j/log4j2/trunk/log4j-core/pom.xml
Date Sun, 30 Mar 2014 18:17:39 GMT
If anyone can inform me why we have spring-test as a dependency, that'd be
great.


On 30 March 2014 13:07, <mattsicker@apache.org> wrote:

> Author: mattsicker
> Date: Sun Mar 30 18:07:43 2014
> New Revision: 1583172
>
> URL: http://svn.apache.org/r1583172
> Log:
> Organise the log4j-core pom.
>
>   - Added some comments.
>   - Collected the test-scoped dependencies into its own "group".
>
> Modified:
>     logging/log4j/log4j2/trunk/log4j-core/pom.xml
>
> Modified: logging/log4j/log4j2/trunk/log4j-core/pom.xml
> URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/pom.xml?rev=1583172&r1=1583171&r2=1583172&view=diff
>
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-core/pom.xml (original)
> +++ logging/log4j/log4j2/trunk/log4j-core/pom.xml Sun Mar 30 18:07:43 2014
> @@ -33,58 +33,112 @@
>      <projectDir>/core</projectDir>
>    </properties>
>    <dependencies>
> +    <!-- Naturally, all implementations require the log4j-api JAR -->
>      <dependency>
>        <groupId>org.apache.logging.log4j</groupId>
>        <artifactId>log4j-api</artifactId>
>      </dependency>
> -    <dependency>
> -      <groupId>org.apache.logging.log4j</groupId>
> -      <artifactId>log4j-api</artifactId>
> -      <type>test-jar</type>
> -      <scope>test</scope>
> -    </dependency>
> +    <!-- Used for OSGi bundle support -->
>      <dependency>
>        <groupId>org.osgi</groupId>
>        <artifactId>core</artifactId>
>        <scope>provided</scope>
>      </dependency>
> +    <!-- Required for AsyncLoggers -->
>      <dependency>
>        <groupId>com.lmax</groupId>
>        <artifactId>disruptor</artifactId>
>        <optional>true</optional>
>      </dependency>
> +    <!-- Required for JSON support -->
>      <dependency>
>        <groupId>com.fasterxml.jackson.core</groupId>
>        <artifactId>jackson-core</artifactId>
>        <optional>true</optional>
>      </dependency>
> +    <!-- Also required for JSON support -->
>      <dependency>
>        <groupId>com.fasterxml.jackson.core</groupId>
>        <artifactId>jackson-databind</artifactId>
>        <optional>true</optional>
>      </dependency>
> +    <!-- Required for YAML support (including JSON requirements) -->
>      <dependency>
>        <groupId>com.fasterxml.jackson.dataformat</groupId>
>        <artifactId>jackson-dataformat-yaml</artifactId>
>        <optional>true</optional>
>      </dependency>
> +    <!-- Required for console color support in Windows -->
>      <dependency>
>        <groupId>org.fusesource.jansi</groupId>
>        <artifactId>jansi</artifactId>
>        <optional>true</optional>
>      </dependency>
> +    <!-- Used for JMS appenders (needs an implementation of course) -->
> +    <dependency>
> +      <groupId>org.apache.geronimo.specs</groupId>
> +      <artifactId>geronimo-jms_1.1_spec</artifactId>
> +      <optional>true</optional>
> +    </dependency>
> +    <!-- Required for SMTPAppender -->
> +    <dependency>
> +      <groupId>com.sun.mail</groupId>
> +      <artifactId>javax.mail</artifactId>
> +      <optional>true</optional>
> +    </dependency>
> +    <!-- Used for web container support -->
> +    <dependency>
> +      <groupId>javax.servlet</groupId>
> +      <artifactId>javax.servlet-api</artifactId>
> +      <version>3.0.1</version>
> +      <scope>provided</scope>
> +    </dependency>
> +    <!-- Used for JPA appenders (needs an implementation of course) -->
> +    <dependency>
> +      <groupId>org.eclipse.persistence</groupId>
> +      <artifactId>javax.persistence</artifactId>
> +      <scope>compile</scope>
> +      <optional>true</optional>
> +    </dependency>
> +    <!-- Required for MongoDB NoSQLAppender -->
> +    <dependency>
> +      <groupId>org.mongodb</groupId>
> +      <artifactId>mongo-java-driver</artifactId>
> +      <scope>compile</scope>
> +      <optional>true</optional>
> +    </dependency>
> +    <!-- Required for CouchDB NoSQLAppender -->
> +    <dependency>
> +      <groupId>org.lightcouch</groupId>
> +      <artifactId>lightcouch</artifactId>
> +      <scope>compile</scope>
> +      <optional>true</optional>
> +    </dependency>
> +
> +    <!-- TEST DEPENDENCIES -->
> +
> +    <!-- Pull in useful test classes from API -->
> +    <dependency>
> +      <groupId>org.apache.logging.log4j</groupId>
> +      <artifactId>log4j-api</artifactId>
> +      <type>test-jar</type>
> +      <scope>test</scope>
> +    </dependency>
> +    <!-- Advertiser tests -->
>      <dependency>
>        <groupId>javax.jmdns</groupId>
>        <artifactId>jmdns</artifactId>
>        <version>3.4.1</version>
>        <scope>test</scope>
>      </dependency>
> +    <!-- Log4j 1.2 tests -->
>      <dependency>
>        <groupId>log4j</groupId>
>        <artifactId>log4j</artifactId>
>        <version>1.2.17</version>
>        <scope>test</scope>
>      </dependency>
> +    <!-- SLF4J tests -->
>      <dependency>
>        <groupId>org.slf4j</groupId>
>        <artifactId>slf4j-api</artifactId>
> @@ -95,16 +149,19 @@
>        <artifactId>slf4j-ext</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- JUnit, naturally -->
>      <dependency>
>        <groupId>junit</groupId>
>        <artifactId>junit</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- Mocking framework for use with JUnit -->
>      <dependency>
>        <groupId>org.easymock</groupId>
>        <artifactId>easymock</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- Embedded JDBC drivers for database appender tests -->
>      <dependency>
>        <groupId>org.hsqldb</groupId>
>        <artifactId>hsqldb</artifactId>
> @@ -115,16 +172,19 @@
>        <artifactId>h2</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- JPA Tests -->
>      <dependency>
>        <groupId>org.eclipse.persistence</groupId>
>        <artifactId>org.eclipse.persistence.jpa</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- JNDI tests -->
>      <dependency>
>        <groupId>org.mockejb</groupId>
>        <artifactId>mockejb</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- Logback performance tests -->
>      <dependency>
>        <groupId>ch.qos.logback</groupId>
>        <artifactId>logback-core</artifactId>
> @@ -135,45 +195,13 @@
>        <artifactId>logback-classic</artifactId>
>        <scope>test</scope>
>      </dependency>
> -    <dependency>
> -      <groupId>org.apache.geronimo.specs</groupId>
> -      <artifactId>geronimo-jms_1.1_spec</artifactId>
> -      <optional>true</optional>
> -    </dependency>
> -    <dependency>
> -      <groupId>com.sun.mail</groupId>
> -      <artifactId>javax.mail</artifactId>
> -      <optional>true</optional>
> -    </dependency>
> -    <dependency>
> -      <groupId>javax.servlet</groupId>
> -      <artifactId>javax.servlet-api</artifactId>
> -      <version>3.0.1</version>
> -      <scope>provided</scope>
> -    </dependency>
> -    <dependency>
> -      <groupId>org.eclipse.persistence</groupId>
> -      <artifactId>javax.persistence</artifactId>
> -      <scope>compile</scope>
> -      <optional>true</optional>
> -    </dependency>
> -    <dependency>
> -      <groupId>org.mongodb</groupId>
> -      <artifactId>mongo-java-driver</artifactId>
> -      <scope>compile</scope>
> -      <optional>true</optional>
> -    </dependency>
> -    <dependency>
> -      <groupId>org.lightcouch</groupId>
> -      <artifactId>lightcouch</artifactId>
> -      <scope>compile</scope>
> -      <optional>true</optional>
> -    </dependency>
> +    <!-- XXX: Spring tests? -->
>      <dependency>
>        <groupId>org.springframework</groupId>
>        <artifactId>spring-test</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <!-- OSGi tests -->
>      <dependency>
>        <groupId>org.eclipse.osgi</groupId>
>        <artifactId>org.eclipse.osgi</artifactId>
>
>
>

Mime
View raw message