logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattsic...@apache.org
Subject svn commit: r1580558 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/ReflectionComparison.java
Date Sun, 23 Mar 2014 18:09:58 GMT
Author: mattsicker
Date: Sun Mar 23 18:09:58 2014
New Revision: 1580558

URL: http://svn.apache.org/r1580558
Log:
Suppress warnings from known deprecated classes.

  - Curses, Oracle/Sun, make this a public API next time!

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/ReflectionComparison.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/ReflectionComparison.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/ReflectionComparison.java?rev=1580558&r1=1580557&r2=1580558&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/ReflectionComparison.java
(original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/ReflectionComparison.java
Sun Mar 23 18:09:58 2014
@@ -16,16 +16,15 @@
  */
 package org.apache.logging.log4j.core.impl;
 
+import java.lang.reflect.Constructor;
+
 import org.apache.logging.log4j.core.Timer;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.message.StringFormattedMessage;
 import org.junit.Test;
-
 import sun.reflect.Reflection;
 
-import java.lang.reflect.Constructor;
-
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertSame;
 
 /**
  * Tests the cost of invoking Reflection.getCallerClass via reflection vs calling it directly.
@@ -45,6 +44,7 @@ public class ReflectionComparison {
         System.out.println(timer.toString());
     }
 
+    @SuppressWarnings("deprecation") // yeah, yeah, we know that they're trying to remove
this API
     @Test
     public void testDirectly() {
         final Timer timer = new Timer("Directly", COUNT);
@@ -57,24 +57,25 @@ public class ReflectionComparison {
         System.out.println(timer.toString());
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testBothMethodsReturnTheSame() {
-        assertEquals("1 is not the same.",
+        assertSame("1 is not the same.",
                 Reflection.getCallerClass(1 + ReflectiveCallerClassUtility.JAVA_7U25_COMPENSATION_OFFSET),
                 ReflectiveCallerClassUtility.getCaller(1));
-        assertEquals("2 is not the same.",
+        assertSame("2 is not the same.",
                 Reflection.getCallerClass(2 + ReflectiveCallerClassUtility.JAVA_7U25_COMPENSATION_OFFSET),
                 ReflectiveCallerClassUtility.getCaller(2));
-        assertEquals("3 is not the same.",
+        assertSame("3 is not the same.",
                 Reflection.getCallerClass(3 + ReflectiveCallerClassUtility.JAVA_7U25_COMPENSATION_OFFSET),
                 ReflectiveCallerClassUtility.getCaller(3));
-        assertEquals("4 is not the same.",
+        assertSame("4 is not the same.",
                 Reflection.getCallerClass(4 + ReflectiveCallerClassUtility.JAVA_7U25_COMPENSATION_OFFSET),
                 ReflectiveCallerClassUtility.getCaller(4));
-        assertEquals("5 is not the same.",
+        assertSame("5 is not the same.",
                 Reflection.getCallerClass(5 + ReflectiveCallerClassUtility.JAVA_7U25_COMPENSATION_OFFSET),
                 ReflectiveCallerClassUtility.getCaller(5));
-        assertEquals("6 is not the same.",
+        assertSame("6 is not the same.",
                 Reflection.getCallerClass(6 + ReflectiveCallerClassUtility.JAVA_7U25_COMPENSATION_OFFSET),
                 ReflectiveCallerClassUtility.getCaller(6));
     }



Mime
View raw message