logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1521686 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java
Date Tue, 10 Sep 2013 23:50:30 GMT
Author: ggregory
Date: Tue Sep 10 23:50:29 2013
New Revision: 1521686

URL: http://svn.apache.org/r1521686
Log:
Statement unnecessarily nested within else clause.

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java?rev=1521686&r1=1521685&r2=1521686&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java
(original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java
Tue Sep 10 23:50:29 2013
@@ -149,9 +149,8 @@ public class SizeBasedTriggeringPolicy i
                 LOGGER.error("Unable to parse numeric part: " + string, e);
                 return MAX_FILE_SIZE;
             }
-        } else {
-            LOGGER.error("Unable to parse bytes: " + string);
-            return MAX_FILE_SIZE;
         }
+        LOGGER.error("Unable to parse bytes: " + string);
+        return MAX_FILE_SIZE;
     }
 }



Mime
View raw message