logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1516449 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java
Date Thu, 22 Aug 2013 13:37:33 GMT
Author: ggregory
Date: Thu Aug 22 13:37:32 2013
New Revision: 1516449

URL: http://svn.apache.org/r1516449
Log:
Statement unnecessarily nested within else clause.

Modified:
    logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java

Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java?rev=1516449&r1=1516448&r2=1516449&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java
(original)
+++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java
Thu Aug 22 13:37:32 2013
@@ -432,10 +432,9 @@ public abstract class ConfigurationFacto
                                 final Configuration c = factory.getConfiguration(source);
                                 if (c != null) {
                                     return c;
-                                } else {
-                                    LOGGER.error("Cannot determine the ConfigurationFactory
to use for {}", config);
-                                    return null;
                                 }
+                                LOGGER.error("Cannot determine the ConfigurationFactory to
use for {}", config);
+                                return null;
                             }
                         }
                     }



Mime
View raw message