logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1514264 - /logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
Date Thu, 15 Aug 2013 13:32:39 GMT
Author: ggregory
Date: Thu Aug 15 13:32:38 2013
New Revision: 1514264

URL: http://svn.apache.org/r1514264
Log:
Statement unnecessarily nested within else clause.

Modified:
    logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java

Modified: logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java?rev=1514264&r1=1514263&r2=1514264&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
(original)
+++ logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java
Thu Aug 15 13:32:38 2013
@@ -260,11 +260,10 @@ public class FlumeConfigurationBuilder {
                         if (sinkUser != null) {
                             throw new ConfigurationException(String.format(
                                 "Sink %s of group %s already in use by group %s", sink, groupName,
sinkUser));
-                        } else {
-                            throw new ConfigurationException(String.format(
-                                "Sink %s of group %s does not exist or is not properly configured",
sink,
-                                groupName));
                         }
+						throw new ConfigurationException(String.format(
+						    "Sink %s of group %s does not exist or is not properly configured", sink,
+						    groupName));
                     }
                     groupSinks.add(s);
                     usedSinks.put(sink, groupName);



Mime
View raw message