logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1487188 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java
Date Wed, 29 May 2013 01:44:09 GMT
Author: ggregory
Date: Wed May 29 01:44:08 2013
New Revision: 1487188

URL: http://svn.apache.org/r1487188
Log:
Statement unnecessarily nested within else clause.

Modified:
    logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java

Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java?rev=1487188&r1=1487187&r2=1487188&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java
(original)
+++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java
Wed May 29 01:44:08 2013
@@ -165,10 +165,9 @@ public class ThrowableAttributeConverter
 
             if (throwable == null) {
                 return null;
-            } else {
-                throwable.setStackTrace(stackTrace);
-                return throwable;
             }
+            throwable.setStackTrace(stackTrace);
+            return throwable;
         } catch (Exception e) {
             return null;
         }



Mime
View raw message