logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1480746 - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java src/changes/changes.xml
Date Thu, 09 May 2013 19:59:26 GMT
Author: ggregory
Date: Thu May  9 19:59:26 2013
New Revision: 1480746

URL: http://svn.apache.org/r1480746
Log:
[LOG4J2-247] SocketServer.isActive should be volatile because it is accessed from different
threads.

Modified:
    logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
    logging/log4j/log4j2/trunk/src/changes/changes.xml

Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java?rev=1480746&r1=1480745&r2=1480746&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
(original)
+++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/SocketServer.java
Thu May  9 19:59:26 2013
@@ -51,7 +51,7 @@ public class SocketServer extends Abstra
 
     private static final int MAX_PORT = 65534;
 
-    private boolean isActive = true;
+    private volatile boolean isActive = true;
 
     private final ServerSocket server;
 

Modified: logging/log4j/log4j2/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/changes/changes.xml?rev=1480746&r1=1480745&r2=1480746&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/changes/changes.xml (original)
+++ logging/log4j/log4j2/trunk/src/changes/changes.xml Thu May  9 19:59:26 2013
@@ -20,8 +20,12 @@
     <title>Changes</title>
     <author email="rgoers@apache.org">Ralph Goers</author>
   </properties>
-
   <body>
+    <release version="2.0-beta7" date="2013-??-??" description="Bug fixes and enhancements">
+      <action issue="LOG4J2-247" dev="ggregory" type="fix">
+        SocketServer.isActive should be volatile because it is accessed from different threads.
+      </action>
+    </release>
     <release version="2.0-beta6" date="2013-05-05" description="Bug fixes and enhancements">
       <action issue="LOG4J2-231" dev="rgoers" type="fix">
         Logger.getParent() was not returning the correct Logger.



Mime
View raw message