logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1419697 [3/17] - in /logging/log4j/log4j2/trunk: api/src/main/java/org/apache/logging/log4j/ api/src/main/java/org/apache/logging/log4j/message/ api/src/main/java/org/apache/logging/log4j/simple/ api/src/main/java/org/apache/logging/log4j/...
Date Mon, 10 Dec 2012 19:37:03 GMT
Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java Mon Dec 10 19:36:06 2012
@@ -86,7 +86,7 @@ public abstract class AbstractLogger imp
      * @param messageFactory
      *            The message factory to check.
      */
-    public static void checkMessageFactory(final Logger logger, MessageFactory messageFactory) {
+    public static void checkMessageFactory(final Logger logger, final MessageFactory messageFactory) {
         final String name = logger.getName();
         final MessageFactory loggerMessageFactory = logger.getMessageFactory();
         if (messageFactory != null && !loggerMessageFactory.equals(messageFactory)) {
@@ -116,7 +116,7 @@ public abstract class AbstractLogger imp
      *
      * @param name the logger name
      */
-    public AbstractLogger(String name) {
+    public AbstractLogger(final String name) {
         this.name = name;
         this.messageFactory = createDefaultMessageFactory();
     }
@@ -127,7 +127,7 @@ public abstract class AbstractLogger imp
      * @param name the logger name
      * @param messageFactory the message factory, if null then use the default message factory.
      */
-    public AbstractLogger(String name, MessageFactory messageFactory) {
+    public AbstractLogger(final String name, final MessageFactory messageFactory) {
         this.name = name;
         this.messageFactory = messageFactory == null ? createDefaultMessageFactory() : messageFactory;
     }
@@ -135,9 +135,9 @@ public abstract class AbstractLogger imp
     private MessageFactory createDefaultMessageFactory() {
         try {
             return DEFAULT_MESSAGE_FACTORY_CLASS.newInstance();
-        } catch (InstantiationException e) {
+        } catch (final InstantiationException e) {
             throw new IllegalStateException(e);
-        } catch (IllegalAccessException e) {
+        } catch (final IllegalAccessException e) {
             throw new IllegalStateException(e);
         }
     }
@@ -156,7 +156,7 @@ public abstract class AbstractLogger imp
      *
      * @param params The parameters to the method.
      */
-    public void entry(Object... params) {
+    public void entry(final Object... params) {
         if (isEnabled(Level.TRACE, ENTRY_MARKER, (Object) null, null)) {
             log(ENTRY_MARKER, FQCN, Level.TRACE, entryMsg(params.length, params), null);
         }
@@ -178,7 +178,7 @@ public abstract class AbstractLogger imp
      * @param result The result being returned from the method call.
      * @return the Throwable.
      */
-    public <R> R exit(R result) {
+    public <R> R exit(final R result) {
         if (isEnabled(Level.TRACE, EXIT_MARKER, (Object) null, null)) {
             log(EXIT_MARKER, FQCN, Level.TRACE, toExitMsg(result), null);
         }
@@ -192,7 +192,7 @@ public abstract class AbstractLogger imp
      * @param t The Throwable.
      * @return the Throwable.
      */
-    public <T extends Throwable> T throwing(T t) {
+    public <T extends Throwable> T throwing(final T t) {
         if (isEnabled(Level.ERROR, THROWING_MARKER, (Object) null, null)) {
             log(THROWING_MARKER, FQCN, Level.ERROR, messageFactory.newMessage(THROWING), t);
         }
@@ -208,7 +208,7 @@ public abstract class AbstractLogger imp
      * @param t     The Throwable.
      * @return the Throwable.
      */
-    public <T extends Throwable> T throwing(Level level, T t) {
+    public <T extends Throwable> T throwing(final Level level, final T t) {
         if (isEnabled(level, THROWING_MARKER, (Object) null, null)) {
             log(THROWING_MARKER, FQCN, level, messageFactory.newMessage(THROWING), t);
         }
@@ -220,7 +220,7 @@ public abstract class AbstractLogger imp
      *
      * @param t The Throwable.
      */
-    public void catching(Throwable t) {
+    public void catching(final Throwable t) {
         if (isEnabled(Level.ERROR, CATCHING_MARKER, (Object) null, null)) {
             log(CATCHING_MARKER, FQCN, Level.ERROR, messageFactory.newMessage(CATCHING), t);
         }
@@ -232,7 +232,7 @@ public abstract class AbstractLogger imp
      * @param level The logging Level.
      * @param t     The Throwable.
      */
-    public void catching(Level level, Throwable t) {
+    public void catching(final Level level, final Throwable t) {
         if (isEnabled(level, CATCHING_MARKER, (Object) null, null)) {
             log(CATCHING_MARKER, FQCN, level, messageFactory.newMessage(CATCHING), t);
         }
@@ -243,7 +243,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void trace(String message) {
+    public void trace(final String message) {
         if (isEnabled(Level.TRACE, null, message)) {
             log(null, FQCN, Level.TRACE, messageFactory.newMessage(message), null);
         }
@@ -255,7 +255,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void trace(Marker marker, String message) {
+    public void trace(final Marker marker, final String message) {
         if (isEnabled(Level.TRACE, marker, message)) {
             log(marker, FQCN, Level.TRACE, messageFactory.newMessage(message), null);
         }
@@ -272,7 +272,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void trace(String message, Throwable t) {
+    public void trace(final String message, final Throwable t) {
         if (isEnabled(Level.TRACE, null, message, t)) {
             log(null, FQCN, Level.TRACE, messageFactory.newMessage(message), t);
         }
@@ -290,7 +290,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void trace(Marker marker, String message, Throwable t) {
+    public void trace(final Marker marker, final String message, final Throwable t) {
         if (isEnabled(Level.TRACE, marker, message, t)) {
             log(marker, FQCN, Level.TRACE, messageFactory.newMessage(message), t);
         }
@@ -301,7 +301,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void trace(Object message) {
+    public void trace(final Object message) {
         if (isEnabled(Level.TRACE, null, message, null)) {
             log(null, FQCN, Level.TRACE, messageFactory.newMessage(message), null);
         }
@@ -313,7 +313,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void trace(Marker marker, Object message) {
+    public void trace(final Marker marker, final Object message) {
         if (isEnabled(Level.TRACE, marker, message, null)) {
             log(marker, FQCN, Level.TRACE, messageFactory.newMessage(message), null);
         }
@@ -330,7 +330,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void trace(Object message, Throwable t) {
+    public void trace(final Object message, final Throwable t) {
         if (isEnabled(Level.TRACE, null, message, t)) {
             log(null, FQCN, Level.TRACE, messageFactory.newMessage(message), t);
         }
@@ -348,7 +348,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void trace(Marker marker, Object message, Throwable t) {
+    public void trace(final Marker marker, final Object message, final Throwable t) {
         if (isEnabled(Level.TRACE, marker, message, t)) {
             log(marker, FQCN, Level.TRACE, messageFactory.newMessage(message), t);
         }
@@ -360,9 +360,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void trace(String message, Object... params) {
+    public void trace(final String message, final Object... params) {
         if (isEnabled(Level.TRACE, null, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(null, FQCN, Level.TRACE, msg, msg.getThrowable());
         }
     }
@@ -374,9 +374,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void trace(Marker marker, String message, Object... params) {
+    public void trace(final Marker marker, final String message, final Object... params) {
         if (isEnabled(Level.TRACE, marker, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(marker, FQCN, Level.TRACE, msg, msg.getThrowable());
         }
     }
@@ -398,7 +398,7 @@ public abstract class AbstractLogger imp
      * @return boolean - {@code true} if this Logger is enabled for level
      *         TRACE, {@code false} otherwise.
      */
-    public boolean isTraceEnabled(Marker marker) {
+    public boolean isTraceEnabled(final Marker marker) {
         return isEnabled(Level.TRACE, marker, (Object) null, null);
     }
 
@@ -407,7 +407,7 @@ public abstract class AbstractLogger imp
      *
      * @param msg the message string to be logged
      */
-    public void trace(Message msg) {
+    public void trace(final Message msg) {
         if (isEnabled(Level.TRACE, null, msg, null)) {
             log(null, FQCN, Level.TRACE, msg, null);
         }
@@ -419,7 +419,7 @@ public abstract class AbstractLogger imp
      * @param msg the message string to be logged
      * @param t   A Throwable or null.
      */
-    public void trace(Message msg, Throwable t) {
+    public void trace(final Message msg, final Throwable t) {
         if (isEnabled(Level.TRACE, null, msg, t)) {
             log(null, FQCN, Level.TRACE, msg, t);
         }
@@ -431,7 +431,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param msg    the message string to be logged
      */
-    public void trace(Marker marker, Message msg) {
+    public void trace(final Marker marker, final Message msg) {
         if (isEnabled(Level.TRACE, marker, msg, null)) {
             log(marker, FQCN, Level.TRACE, msg, null);
         }
@@ -444,7 +444,7 @@ public abstract class AbstractLogger imp
      * @param msg    the message string to be logged
      * @param t      A Throwable or null.
      */
-    public void trace(Marker marker, Message msg, Throwable t) {
+    public void trace(final Marker marker, final Message msg, final Throwable t) {
         if (isEnabled(Level.TRACE, marker, msg, t)) {
             log(marker, FQCN, Level.TRACE, msg, t);
         }
@@ -455,7 +455,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void debug(String message) {
+    public void debug(final String message) {
         if (isEnabled(Level.DEBUG, null, message)) {
             log(null, FQCN, Level.DEBUG, messageFactory.newMessage(message), null);
         }
@@ -467,7 +467,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void debug(Marker marker, String message) {
+    public void debug(final Marker marker, final String message) {
         if (isEnabled(Level.DEBUG, marker, message)) {
             log(marker, FQCN, Level.DEBUG, messageFactory.newMessage(message), null);
         }
@@ -480,7 +480,7 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void debug(String message, Throwable t) {
+    public void debug(final String message, final Throwable t) {
         if (isEnabled(Level.DEBUG, null, message, t)) {
             log(null, FQCN, Level.DEBUG, messageFactory.newMessage(message), t);
         }
@@ -494,7 +494,7 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void debug(Marker marker, String message, Throwable t) {
+    public void debug(final Marker marker, final String message, final Throwable t) {
         if (isEnabled(Level.DEBUG, marker, message, t)) {
             log(marker, FQCN, Level.DEBUG, messageFactory.newMessage(message), t);
         }
@@ -504,7 +504,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void debug(Object message) {
+    public void debug(final Object message) {
         if (isEnabled(Level.DEBUG, null, message, null)) {
             log(null, FQCN, Level.DEBUG, messageFactory.newMessage(message), null);
         }
@@ -516,7 +516,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void debug(Marker marker, Object message) {
+    public void debug(final Marker marker, final Object message) {
         if (isEnabled(Level.DEBUG, marker, message, null)) {
             log(marker, FQCN, Level.DEBUG, messageFactory.newMessage(message), null);
         }
@@ -529,7 +529,7 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void debug(Object message, Throwable t) {
+    public void debug(final Object message, final Throwable t) {
         if (isEnabled(Level.DEBUG, null, message, t)) {
             log(null, FQCN, Level.DEBUG, messageFactory.newMessage(message), t);
         }
@@ -543,7 +543,7 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void debug(Marker marker, Object message, Throwable t) {
+    public void debug(final Marker marker, final Object message, final Throwable t) {
         if (isEnabled(Level.DEBUG, marker, message, t)) {
             log(marker, FQCN, Level.DEBUG, messageFactory.newMessage(message), t);
         }
@@ -555,9 +555,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void debug(String message, Object... params) {
+    public void debug(final String message, final Object... params) {
         if (isEnabled(Level.DEBUG, null, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(null, FQCN, Level.DEBUG, msg, msg.getThrowable());
         }
     }
@@ -569,9 +569,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void debug(Marker marker, String message, Object... params) {
+    public void debug(final Marker marker, final String message, final Object... params) {
         if (isEnabled(Level.DEBUG, marker, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(marker, FQCN, Level.DEBUG, msg, msg.getThrowable());
         }
     }
@@ -593,7 +593,7 @@ public abstract class AbstractLogger imp
      * @return boolean - {@code true} if this Logger is enabled for level
      *         DEBUG, {@code false} otherwise.
      */
-    public boolean isDebugEnabled(Marker marker) {
+    public boolean isDebugEnabled(final Marker marker) {
         return isEnabled(Level.DEBUG, marker, (Object) null, null);
     }
 
@@ -602,7 +602,7 @@ public abstract class AbstractLogger imp
      *
      * @param msg the message string to be logged
      */
-    public void debug(Message msg) {
+    public void debug(final Message msg) {
         if (isEnabled(Level.DEBUG, null, msg, null)) {
             log(null, FQCN, Level.DEBUG, msg, null);
         }
@@ -614,7 +614,7 @@ public abstract class AbstractLogger imp
      * @param msg the message string to be logged
      * @param t   A Throwable or null.
      */
-    public void debug(Message msg, Throwable t) {
+    public void debug(final Message msg, final Throwable t) {
         if (isEnabled(Level.DEBUG, null, msg, t)) {
             log(null, FQCN, Level.DEBUG, msg, t);
         }
@@ -626,7 +626,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement
      * @param msg    the message string to be logged
      */
-    public void debug(Marker marker, Message msg) {
+    public void debug(final Marker marker, final Message msg) {
         if (isEnabled(Level.DEBUG, marker, msg, null)) {
             log(marker, FQCN, Level.DEBUG, msg, null);
         }
@@ -639,7 +639,7 @@ public abstract class AbstractLogger imp
      * @param msg    the message string to be logged
      * @param t      A Throwable or null.
      */
-    public void debug(Marker marker, Message msg, Throwable t) {
+    public void debug(final Marker marker, final Message msg, final Throwable t) {
         if (isEnabled(Level.DEBUG, marker, msg, t)) {
             log(marker, FQCN, Level.DEBUG, msg, t);
         }
@@ -650,7 +650,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void info(String message) {
+    public void info(final String message) {
         if (isEnabled(Level.INFO, null, message)) {
             log(null, FQCN, Level.INFO, messageFactory.newMessage(message), null);
         }
@@ -662,7 +662,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void info(Marker marker, String message) {
+    public void info(final Marker marker, final String message) {
         if (isEnabled(Level.INFO, marker, message)) {
             log(marker, FQCN, Level.INFO, messageFactory.newMessage(message), null);
         }
@@ -675,7 +675,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void info(String message, Throwable t) {
+    public void info(final String message, final Throwable t) {
         if (isEnabled(Level.INFO, null, message, t)) {
             log(null, FQCN, Level.INFO, messageFactory.newMessage(message), t);
         }
@@ -689,7 +689,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void info(Marker marker, String message, Throwable t) {
+    public void info(final Marker marker, final String message, final Throwable t) {
         if (isEnabled(Level.INFO, marker, message, t)) {
             log(marker, FQCN, Level.INFO, messageFactory.newMessage(message), t);
         }
@@ -700,7 +700,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void info(Object message) {
+    public void info(final Object message) {
         if (isEnabled(Level.INFO, null, message, null)) {
             log(null, FQCN, Level.INFO, messageFactory.newMessage(message), null);
         }
@@ -712,7 +712,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void info(Marker marker, Object message) {
+    public void info(final Marker marker, final Object message) {
         if (isEnabled(Level.INFO, marker, message, null)) {
             log(marker, FQCN, Level.INFO, messageFactory.newMessage(message), null);
         }
@@ -725,7 +725,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void info(Object message, Throwable t) {
+    public void info(final Object message, final Throwable t) {
         if (isEnabled(Level.INFO, null, message, t)) {
             log(null, FQCN, Level.INFO, messageFactory.newMessage(message), t);
         }
@@ -740,7 +740,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void info(Marker marker, Object message, Throwable t) {
+    public void info(final Marker marker, final Object message, final Throwable t) {
         if (isEnabled(Level.INFO, marker, message, t)) {
             log(marker, FQCN, Level.INFO, messageFactory.newMessage(message), t);
         }
@@ -752,9 +752,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void info(String message, Object... params) {
+    public void info(final String message, final Object... params) {
         if (isEnabled(Level.INFO, null, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(null, FQCN, Level.INFO, msg, msg.getThrowable());
         }
     }
@@ -766,9 +766,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void info(Marker marker, String message, Object... params) {
+    public void info(final Marker marker, final String message, final Object... params) {
         if (isEnabled(Level.INFO, marker, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(marker, FQCN, Level.INFO, msg, msg.getThrowable());
         }
     }
@@ -789,7 +789,7 @@ public abstract class AbstractLogger imp
      * @return boolean - {@code true} if this Logger is enabled for level
      *         INFO, {@code false} otherwise.
      */
-    public boolean isInfoEnabled(Marker marker) {
+    public boolean isInfoEnabled(final Marker marker) {
         return isEnabled(Level.INFO, marker, (Object) null, null);
     }
 
@@ -798,7 +798,7 @@ public abstract class AbstractLogger imp
      *
      * @param msg the message string to be logged
      */
-    public void info(Message msg) {
+    public void info(final Message msg) {
         if (isEnabled(Level.INFO, null, msg, null)) {
             log(null, FQCN, Level.INFO, msg, null);
         }
@@ -810,7 +810,7 @@ public abstract class AbstractLogger imp
      * @param msg the message string to be logged
      * @param t   A Throwable or null.
      */
-    public void info(Message msg, Throwable t) {
+    public void info(final Message msg, final Throwable t) {
         if (isEnabled(Level.INFO, null, msg, t)) {
             log(null, FQCN, Level.INFO, msg, t);
         }
@@ -822,7 +822,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement
      * @param msg    the message string to be logged
      */
-    public void info(Marker marker, Message msg) {
+    public void info(final Marker marker, final Message msg) {
         if (isEnabled(Level.INFO, marker, msg, null)) {
             log(marker, FQCN, Level.INFO, msg, null);
         }
@@ -835,7 +835,7 @@ public abstract class AbstractLogger imp
      * @param msg    the message string to be logged
      * @param t      A Throwable or null.
      */
-    public void info(Marker marker, Message msg, Throwable t) {
+    public void info(final Marker marker, final Message msg, final Throwable t) {
         if (isEnabled(Level.INFO, marker, msg, t)) {
             log(marker, FQCN, Level.INFO, msg, t);
         }
@@ -846,7 +846,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void warn(String message) {
+    public void warn(final String message) {
         if (isEnabled(Level.WARN, null, message)) {
             log(null, FQCN, Level.WARN, messageFactory.newMessage(message), null);
         }
@@ -858,7 +858,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void warn(Marker marker, String message) {
+    public void warn(final Marker marker, final String message) {
         if (isEnabled(Level.WARN, marker, message)) {
             log(marker, FQCN, Level.WARN, messageFactory.newMessage(message), null);
         }
@@ -871,7 +871,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void warn(String message, Throwable t) {
+    public void warn(final String message, final Throwable t) {
         if (isEnabled(Level.WARN, null, message, t)) {
             log(null, FQCN, Level.WARN, messageFactory.newMessage(message), t);
         }
@@ -885,7 +885,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void warn(Marker marker, String message, Throwable t) {
+    public void warn(final Marker marker, final String message, final Throwable t) {
         if (isEnabled(Level.WARN, marker, message, t)) {
             log(marker, FQCN, Level.WARN, messageFactory.newMessage(message), t);
         }
@@ -897,7 +897,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void warn(Marker marker, Object message) {
+    public void warn(final Marker marker, final Object message) {
         if (isEnabled(Level.WARN, marker, message, null)) {
             log(marker, FQCN, Level.WARN, messageFactory.newMessage(message), null);
         }
@@ -908,7 +908,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void warn(Object message) {
+    public void warn(final Object message) {
         if (isEnabled(Level.WARN, null, message, null)) {
             log(null, FQCN, Level.WARN, messageFactory.newMessage(message), null);
         }
@@ -921,7 +921,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void warn(Object message, Throwable t) {
+    public void warn(final Object message, final Throwable t) {
         if (isEnabled(Level.WARN, null, message, t)) {
             log(null, FQCN, Level.WARN, messageFactory.newMessage(message), t);
         }
@@ -935,7 +935,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void warn(Marker marker, Object message, Throwable t) {
+    public void warn(final Marker marker, final Object message, final Throwable t) {
         if (isEnabled(Level.WARN, marker, message, t)) {
             log(marker, FQCN, Level.WARN, messageFactory.newMessage(message), t);
         }
@@ -947,9 +947,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void warn(String message, Object... params) {
+    public void warn(final String message, final Object... params) {
         if (isEnabled(Level.WARN, null, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(null, FQCN, Level.WARN, msg, msg.getThrowable());
         }
     }
@@ -961,9 +961,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void warn(Marker marker, String message, Object... params) {
+    public void warn(final Marker marker, final String message, final Object... params) {
         if (isEnabled(Level.WARN, marker, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(marker, FQCN, Level.WARN, msg, msg.getThrowable());
         }
     }
@@ -986,7 +986,7 @@ public abstract class AbstractLogger imp
      * @return boolean - {@code true} if this Logger is enabled for level
      *         WARN, {@code false} otherwise.
      */
-    public boolean isWarnEnabled(Marker marker) {
+    public boolean isWarnEnabled(final Marker marker) {
         return isEnabled(Level.WARN, marker, (Object) null, null);
     }
 
@@ -995,7 +995,7 @@ public abstract class AbstractLogger imp
      *
      * @param msg the message string to be logged
      */
-    public void warn(Message msg) {
+    public void warn(final Message msg) {
         if (isEnabled(Level.WARN, null, msg, null)) {
             log(null, FQCN, Level.WARN, msg, null);
         }
@@ -1007,7 +1007,7 @@ public abstract class AbstractLogger imp
      * @param msg the message string to be logged
      * @param t   A Throwable or null.
      */
-    public void warn(Message msg, Throwable t) {
+    public void warn(final Message msg, final Throwable t) {
         if (isEnabled(Level.WARN, null, msg, t)) {
             log(null, FQCN, Level.WARN, msg, t);
         }
@@ -1019,7 +1019,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement
      * @param msg    the message string to be logged
      */
-    public void warn(Marker marker, Message msg) {
+    public void warn(final Marker marker, final Message msg) {
         if (isEnabled(Level.WARN, marker, msg, null)) {
             log(marker, FQCN, Level.WARN, msg, null);
         }
@@ -1032,7 +1032,7 @@ public abstract class AbstractLogger imp
      * @param msg    the message string to be logged
      * @param t      A Throwable or null.
      */
-    public void warn(Marker marker, Message msg, Throwable t) {
+    public void warn(final Marker marker, final Message msg, final Throwable t) {
         if (isEnabled(Level.WARN, marker, msg, t)) {
             log(marker, FQCN, Level.WARN, msg, t);
         }
@@ -1043,7 +1043,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void error(String message) {
+    public void error(final String message) {
         if (isEnabled(Level.ERROR, null, message)) {
             log(null, FQCN, Level.ERROR, messageFactory.newMessage(message), null);
         }
@@ -1055,7 +1055,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void error(Marker marker, String message) {
+    public void error(final Marker marker, final String message) {
         if (isEnabled(Level.ERROR, marker, message)) {
             log(marker, FQCN, Level.ERROR, messageFactory.newMessage(message), null);
         }
@@ -1068,7 +1068,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void error(String message, Throwable t) {
+    public void error(final String message, final Throwable t) {
         if (isEnabled(Level.ERROR, null, message, t)) {
             log(null, FQCN, Level.ERROR, messageFactory.newMessage(message), t);
         }
@@ -1082,7 +1082,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void error(Marker marker, String message, Throwable t) {
+    public void error(final Marker marker, final String message, final Throwable t) {
         if (isEnabled(Level.ERROR, marker, message, t)) {
             log(marker, FQCN, Level.ERROR, messageFactory.newMessage(message), t);
         }
@@ -1093,7 +1093,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void error(Object message) {
+    public void error(final Object message) {
         if (isEnabled(Level.ERROR, null, message, null)) {
             log(null, FQCN, Level.ERROR, messageFactory.newMessage(message), null);
         }
@@ -1105,7 +1105,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void error(Marker marker, Object message) {
+    public void error(final Marker marker, final Object message) {
         if (isEnabled(Level.ERROR, marker, message, null)) {
             log(marker, FQCN, Level.ERROR, messageFactory.newMessage(message), null);
         }
@@ -1118,7 +1118,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void error(Object message, Throwable t) {
+    public void error(final Object message, final Throwable t) {
         if (isEnabled(Level.ERROR, null, message, t)) {
             log(null, FQCN, Level.ERROR, messageFactory.newMessage(message), t);
         }
@@ -1132,7 +1132,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void error(Marker marker, Object message, Throwable t) {
+    public void error(final Marker marker, final Object message, final Throwable t) {
         if (isEnabled(Level.ERROR, marker, message, t)) {
             log(marker, FQCN, Level.ERROR, messageFactory.newMessage(message), t);
         }
@@ -1144,9 +1144,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void error(String message, Object... params) {
+    public void error(final String message, final Object... params) {
         if (isEnabled(Level.ERROR, null, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(null, FQCN, Level.ERROR, msg, msg.getThrowable());
         }
     }
@@ -1158,9 +1158,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void error(Marker marker, String message, Object... params) {
+    public void error(final Marker marker, final String message, final Object... params) {
         if (isEnabled(Level.ERROR, marker, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(marker, FQCN, Level.ERROR, msg, msg.getThrowable());
         }
     }
@@ -1183,7 +1183,7 @@ public abstract class AbstractLogger imp
      * @return boolean - {@code true} if this Logger is enabled for level
      *         {@link Level#ERROR ERROR}, {@code false} otherwise.
      */
-    public boolean isErrorEnabled(Marker marker) {
+    public boolean isErrorEnabled(final Marker marker) {
         return isEnabled(Level.ERROR, marker, (Object) null, null);
     }
 
@@ -1192,7 +1192,7 @@ public abstract class AbstractLogger imp
      *
      * @param msg the message string to be logged
      */
-    public void error(Message msg) {
+    public void error(final Message msg) {
         if (isEnabled(Level.ERROR, null, msg, null)) {
             log(null, FQCN, Level.ERROR, msg, null);
         }
@@ -1204,7 +1204,7 @@ public abstract class AbstractLogger imp
      * @param msg the message string to be logged
      * @param t   A Throwable or null.
      */
-    public void error(Message msg, Throwable t) {
+    public void error(final Message msg, final Throwable t) {
         if (isEnabled(Level.ERROR, null, msg, t)) {
             log(null, FQCN, Level.ERROR, msg, t);
         }
@@ -1216,7 +1216,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement
      * @param msg    the message string to be logged
      */
-    public void error(Marker marker, Message msg) {
+    public void error(final Marker marker, final Message msg) {
         if (isEnabled(Level.ERROR, marker, msg, null)) {
             log(marker, FQCN, Level.ERROR, msg, null);
         }
@@ -1229,7 +1229,7 @@ public abstract class AbstractLogger imp
      * @param msg    the message string to be logged
      * @param t      A Throwable or null.
      */
-    public void error(Marker marker, Message msg, Throwable t) {
+    public void error(final Marker marker, final Message msg, final Throwable t) {
         if (isEnabled(Level.ERROR, marker, msg, t)) {
             log(marker, FQCN, Level.ERROR, msg, t);
         }
@@ -1240,7 +1240,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void fatal(String message) {
+    public void fatal(final String message) {
         if (isEnabled(Level.FATAL, null, message)) {
             log(null, FQCN, Level.FATAL, messageFactory.newMessage(message), null);
         }
@@ -1253,7 +1253,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void fatal(Marker marker, String message) {
+    public void fatal(final Marker marker, final String message) {
         if (isEnabled(Level.FATAL, marker, message)) {
             log(marker, FQCN, Level.FATAL, messageFactory.newMessage(message), null);
         }
@@ -1266,7 +1266,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void fatal(String message, Throwable t) {
+    public void fatal(final String message, final Throwable t) {
         if (isEnabled(Level.FATAL, null, message, t)) {
             log(null, FQCN, Level.FATAL, messageFactory.newMessage(message), t);
         }
@@ -1280,7 +1280,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void fatal(Marker marker, String message, Throwable t) {
+    public void fatal(final Marker marker, final String message, final Throwable t) {
         if (isEnabled(Level.FATAL, marker, message, t)) {
             log(marker, FQCN, Level.FATAL, messageFactory.newMessage(message), t);
         }
@@ -1291,7 +1291,7 @@ public abstract class AbstractLogger imp
      *
      * @param message the message object to log.
      */
-    public void fatal(Object message) {
+    public void fatal(final Object message) {
         if (isEnabled(Level.FATAL, null, message, null)) {
             log(null, FQCN, Level.FATAL, messageFactory.newMessage(message), null);
         }
@@ -1303,7 +1303,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement.
      * @param message the message object to log.
      */
-    public void fatal(Marker marker, Object message) {
+    public void fatal(final Marker marker, final Object message) {
         if (isEnabled(Level.FATAL, marker, message, null)) {
             log(marker, FQCN, Level.FATAL, messageFactory.newMessage(message), null);
         }
@@ -1316,7 +1316,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void fatal(Object message, Throwable t) {
+    public void fatal(final Object message, final Throwable t) {
         if (isEnabled(Level.FATAL, null, message, t)) {
             log(null, FQCN, Level.FATAL, messageFactory.newMessage(message), t);
         }
@@ -1330,7 +1330,7 @@ public abstract class AbstractLogger imp
      * @param message the message object to log.
      * @param t       the exception to log, including its stack trace.
      */
-    public void fatal(Marker marker, Object message, Throwable t) {
+    public void fatal(final Marker marker, final Object message, final Throwable t) {
         if (isEnabled(Level.FATAL, marker, message, t)) {
             log(marker, FQCN, Level.FATAL, messageFactory.newMessage(message), t);
         }
@@ -1342,9 +1342,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void fatal(String message, Object... params) {
+    public void fatal(final String message, final Object... params) {
         if (isEnabled(Level.FATAL, null, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(null, FQCN, Level.FATAL, msg, msg.getThrowable());
         }
     }
@@ -1356,9 +1356,9 @@ public abstract class AbstractLogger imp
      * @param message the message to log.
      * @param params  parameters to the message.
      */
-    public void fatal(Marker marker, String message, Object... params) {
+    public void fatal(final Marker marker, final String message, final Object... params) {
         if (isEnabled(Level.FATAL, marker, message, params)) {
-            Message msg = messageFactory.newMessage(message, params);
+            final Message msg = messageFactory.newMessage(message, params);
             log(marker, FQCN, Level.FATAL, msg, msg.getThrowable());
         }
     }
@@ -1380,7 +1380,7 @@ public abstract class AbstractLogger imp
      * @return boolean - {@code true} if this Logger is enabled for level
      *         FATAL, {@code false} otherwise.
      */
-    public boolean isFatalEnabled(Marker marker) {
+    public boolean isFatalEnabled(final Marker marker) {
         return isEnabled(Level.FATAL, marker, (Object) null, null);
     }
 
@@ -1389,7 +1389,7 @@ public abstract class AbstractLogger imp
      *
      * @param msg the message string to be logged
      */
-    public void fatal(Message msg) {
+    public void fatal(final Message msg) {
         if (isEnabled(Level.FATAL, null, msg, null)) {
             log(null, FQCN, Level.FATAL, msg, null);
         }
@@ -1401,7 +1401,7 @@ public abstract class AbstractLogger imp
      * @param msg the message string to be logged
      * @param t   A Throwable or null.
      */
-    public void fatal(Message msg, Throwable t) {
+    public void fatal(final Message msg, final Throwable t) {
         if (isEnabled(Level.FATAL, null, msg, t)) {
             log(null, FQCN, Level.FATAL, msg, t);
         }
@@ -1413,7 +1413,7 @@ public abstract class AbstractLogger imp
      * @param marker the marker data specific to this log statement
      * @param msg    the message string to be logged
      */
-    public void fatal(Marker marker, Message msg) {
+    public void fatal(final Marker marker, final Message msg) {
         if (isEnabled(Level.FATAL, marker, msg, null)) {
             log(marker, FQCN, Level.FATAL, msg, null);
         }
@@ -1426,7 +1426,7 @@ public abstract class AbstractLogger imp
      * @param msg    the message string to be logged
      * @param t      A Throwable or null.
      */
-    public void fatal(Marker marker, Message msg, Throwable t) {
+    public void fatal(final Marker marker, final Message msg, final Throwable t) {
         if (isEnabled(Level.FATAL, marker, msg, t)) {
             log(marker, FQCN, Level.FATAL, msg, t);
         }
@@ -1496,7 +1496,7 @@ public abstract class AbstractLogger imp
      * @param level the level to check
      * @return boolean - {@code true} if this Logger is enabled for level, {@code false} otherwise.
      */
-    public boolean isEnabled(Level level) {
+    public boolean isEnabled(final Level level) {
         return isEnabled(level, null, (Object) null, null);
     }
 
@@ -1510,13 +1510,13 @@ public abstract class AbstractLogger imp
      */
     protected abstract boolean isEnabled(Level level, Marker marker, Message data, Throwable t);
 
-    private Message entryMsg(int count, Object... params) {
+    private Message entryMsg(final int count, final Object... params) {
         if (count == 0) {
             return messageFactory.newMessage(" entry");
         }
-        StringBuilder sb = new StringBuilder(" entry parms(");
+        final StringBuilder sb = new StringBuilder(" entry parms(");
         int i = 0;
-        for (Object parm : params) {
+        for (final Object parm : params) {
             if (parm != null) {
                 sb.append(parm.toString());
             } else {
@@ -1530,7 +1530,7 @@ public abstract class AbstractLogger imp
         return messageFactory.newMessage(sb.toString());
     }
 
-    private Message toExitMsg(Object result) {
+    private Message toExitMsg(final Object result) {
         if (result == null) {
             return messageFactory.newMessage(" exit");
         }

Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerWrapper.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerWrapper.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerWrapper.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerWrapper.java Mon Dec 10 19:36:06 2012
@@ -37,7 +37,7 @@ public class AbstractLoggerWrapper exten
      * @param name The name of the Logger.
      * @param messageFactory TODO
      */
-    public AbstractLoggerWrapper(AbstractLogger logger, String name, MessageFactory messageFactory) {
+    public AbstractLoggerWrapper(final AbstractLogger logger, final String name, final MessageFactory messageFactory) {
         super(name, messageFactory);
         this.logger = logger;
     }
@@ -51,7 +51,7 @@ public class AbstractLoggerWrapper exten
      * @param t      A Throwable or null.
      */
     @Override
-    public void log(Marker marker, String fqcn, Level level, Message data, Throwable t) {
+    public void log(final Marker marker, final String fqcn, final Level level, final Message data, final Throwable t) {
         logger.log(marker, fqcn, level, data, t);
     }
 
@@ -63,7 +63,7 @@ public class AbstractLoggerWrapper exten
      * @return true if the event would be logged for the Level, Marker and data, false otherwise.
      */
     @Override
-    public boolean isEnabled(Level level, Marker marker, String data) {
+    public boolean isEnabled(final Level level, final Marker marker, final String data) {
         return logger.isEnabled(level, marker, data);
     }
 
@@ -76,7 +76,7 @@ public class AbstractLoggerWrapper exten
      * @return true if the event would be logged for the Level, Marker, data and Throwable, false otherwise.
      */
     @Override
-    public boolean isEnabled(Level level, Marker marker, String data, Throwable t) {
+    public boolean isEnabled(final Level level, final Marker marker, final String data, final Throwable t) {
         return logger.isEnabled(level, marker, data, t);
     }
 
@@ -89,7 +89,7 @@ public class AbstractLoggerWrapper exten
      * @return true if the event would be logged for the Level, Marker, data and parameter.
      */
     @Override
-    public boolean isEnabled(Level level, Marker marker, String data, Object... p1) {
+    public boolean isEnabled(final Level level, final Marker marker, final String data, final Object... p1) {
         return logger.isEnabled(level, marker, data, p1);
     }
 
@@ -102,7 +102,7 @@ public class AbstractLoggerWrapper exten
      * @return true if the event would be logged for the Level, Marker, Object and Throwable, false otherwise.
      */
     @Override
-    public boolean isEnabled(Level level, Marker marker, Object data, Throwable t) {
+    public boolean isEnabled(final Level level, final Marker marker, final Object data, final Throwable t) {
         return logger.isEnabled(level, marker, data, t);
     }
 
@@ -115,7 +115,7 @@ public class AbstractLoggerWrapper exten
      * @return true if the event would be logged for the Level, Marker, Message and Throwable, false otherwise.
      */
     @Override
-    public boolean isEnabled(Level level, Marker marker, Message data, Throwable t) {
+    public boolean isEnabled(final Level level, final Marker marker, final Message data, final Throwable t) {
         return logger.isEnabled(level, marker, data, t);
     }
 }

Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java Mon Dec 10 19:36:06 2012
@@ -39,7 +39,7 @@ public class StatusConsoleListener imple
      * default value of FATAL.
      */
     public StatusConsoleListener() {
-        String str = System.getProperty(STATUS_LEVEL);
+        final String str = System.getProperty(STATUS_LEVEL);
         if (str != null) {
             level = Level.toLevel(str, Level.FATAL);
         }
@@ -50,7 +50,7 @@ public class StatusConsoleListener imple
      * Creates the StatusConsoleListener using the supplied Level.
      * @param level The Level of status messages that should appear on the console.
      */
-    public StatusConsoleListener(Level level) {
+    public StatusConsoleListener(final Level level) {
         this.level = level;
         stream = System.out;
     }
@@ -60,7 +60,7 @@ public class StatusConsoleListener imple
      * @param level The Level of status messages that should appear on the console.
      * @param stream The PrintStream to write to.
      */
-    public StatusConsoleListener(Level level, PrintStream stream) {
+    public StatusConsoleListener(final Level level, final PrintStream stream) {
         this.level = level;
         this.stream = stream;
     }
@@ -69,7 +69,7 @@ public class StatusConsoleListener imple
      * Sets the level to a new value.
      * @param level The new Level.
      */
-    public void setLevel(Level level) {
+    public void setLevel(final Level level) {
         this.level = level;
     }
 
@@ -77,7 +77,7 @@ public class StatusConsoleListener imple
      * Writes status messages to the console.
      * @param data The StatusData.
      */
-    public void log(StatusData data) {
+    public void log(final StatusData data) {
         if (data.getLevel().isAtLeastAsSpecificAs(level) && !filtered(data)) {
             stream.println(data.getFormattedStatus());
         }
@@ -87,16 +87,16 @@ public class StatusConsoleListener imple
      * Adds package name filters to exclude.
      * @param filters An array of package names to exclude.
      */
-    public void setFilters(String... filters) {
+    public void setFilters(final String... filters) {
         this.filters = filters;
     }
 
-    private boolean filtered(StatusData data) {
+    private boolean filtered(final StatusData data) {
         if (filters == null) {
             return false;
         }
-        String caller = data.getStackTraceElement().getClassName();
-        for (String filter : filters) {
+        final String caller = data.getStackTraceElement().getClassName();
+        for (final String filter : filters) {
             if (caller.startsWith(filter)) {
                 return true;
             }

Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusData.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusData.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusData.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusData.java Mon Dec 10 19:36:06 2012
@@ -46,7 +46,7 @@ public class StatusData {
      * @param msg The message String.
      * @param t The Error or Exception that occurred.
      */
-    public StatusData(StackTraceElement caller, Level level, Message msg, Throwable t) {
+    public StatusData(final StackTraceElement caller, final Level level, final Message msg, final Throwable t) {
         this.timestamp = System.currentTimeMillis();
         this.caller = caller;
         this.level = level;
@@ -99,14 +99,14 @@ public class StatusData {
      * @return The formatted status data as a String.
      */
     public String getFormattedStatus() {
-        StringBuilder sb = new StringBuilder();
-        SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss,SSS");
+        final StringBuilder sb = new StringBuilder();
+        final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss,SSS");
         sb.append(format.format(new Date(timestamp)));
         sb.append(" ");
         sb.append(level.toString());
         sb.append(" ");
         sb.append(msg.getFormattedMessage());
-        Object[] params = msg.getParameters();
+        final Object[] params = msg.getParameters();
         Throwable t;
         if (throwable == null && params != null && params[params.length - 1] instanceof Throwable) {
             t = (Throwable) params[params.length - 1];
@@ -115,7 +115,7 @@ public class StatusData {
         }
         if (t != null) {
             sb.append(" ");
-            ByteArrayOutputStream baos = new ByteArrayOutputStream();
+            final ByteArrayOutputStream baos = new ByteArrayOutputStream();
             t.printStackTrace(new PrintStream(baos));
             sb.append(baos.toString());
         }

Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java Mon Dec 10 19:36:06 2012
@@ -60,7 +60,7 @@ public final class StatusLogger extends 
     private final ReentrantLock msgLock = new ReentrantLock();
 
     private StatusLogger() {
-        PropsUtil props = new PropsUtil("log4j2.StatusLogger.properties");
+        final PropsUtil props = new PropsUtil("log4j2.StatusLogger.properties");
         this.logger = new SimpleLogger("StatusLogger", Level.ERROR, false, true, false, false, "", null, props, System.err);
     }
 
@@ -72,7 +72,7 @@ public final class StatusLogger extends 
         return statusLogger;
     }
 
-    public void setLevel(Level level) {
+    public void setLevel(final Level level) {
         logger.setLevel(level);
     }
 
@@ -80,7 +80,7 @@ public final class StatusLogger extends 
      * Register a new listener.
      * @param listener The StatusListener to register.
      */
-    public void registerListener(StatusListener listener) {
+    public void registerListener(final StatusListener listener) {
         listenersLock.writeLock().lock();
         try {
             listeners.add(listener);
@@ -93,7 +93,7 @@ public final class StatusLogger extends 
      * Remove a StatusListener.
      * @param listener The StatusListener to remove.
      */
-    public void removeListener(StatusListener listener) {
+    public void removeListener(final StatusListener listener) {
         listenersLock.writeLock().lock();
         try {
             listeners.remove(listener);
@@ -153,12 +153,12 @@ public final class StatusLogger extends 
      * @param t      A Throwable or null.
      */
     @Override
-    public void log(Marker marker, String fqcn, Level level, Message msg, Throwable t) {
+    public void log(final Marker marker, final String fqcn, final Level level, final Message msg, final Throwable t) {
         StackTraceElement element = null;
         if (fqcn != null) {
             element = getStackTraceElement(fqcn, Thread.currentThread().getStackTrace());
         }
-        StatusData data = new StatusData(element, level, msg, t);
+        final StatusData data = new StatusData(element, level, msg, t);
         msgLock.lock();
         try {
             messages.add(data);
@@ -166,7 +166,7 @@ public final class StatusLogger extends 
             msgLock.unlock();
         }
         if (listeners.size() > 0) {
-            for (StatusListener listener : listeners) {
+            for (final StatusListener listener : listeners) {
                 listener.log(data);
             }
         } else {
@@ -174,16 +174,16 @@ public final class StatusLogger extends 
         }
     }
 
-    private StackTraceElement getStackTraceElement(String fqcn, StackTraceElement[] stackTrace) {
+    private StackTraceElement getStackTraceElement(final String fqcn, final StackTraceElement[] stackTrace) {
         if (fqcn == null) {
             return null;
         }
         boolean next = false;
-        for (StackTraceElement element : stackTrace) {
+        for (final StackTraceElement element : stackTrace) {
             if (next) {
                 return element;
             }
-            String className = element.getClassName();
+            final String className = element.getClassName();
             if (fqcn.equals(className)) {
                 next = true;
             } else if (NOT_AVAIL.equals(className)) {
@@ -194,31 +194,31 @@ public final class StatusLogger extends 
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String data) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String data) {
         return isEnabled(level, marker);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String data, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String data, final Throwable t) {
         return isEnabled(level, marker);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String data, Object... p1) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String data, final Object... p1) {
         return isEnabled(level, marker);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, Object data, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final Object data, final Throwable t) {
         return isEnabled(level, marker);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, Message data, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final Message data, final Throwable t) {
         return isEnabled(level, marker);
     }
 
-    protected boolean isEnabled(Level level, Marker marker) {
+    protected boolean isEnabled(final Level level, final Marker marker) {
         if (listeners.size() > 0) {
             return true;
         }
@@ -249,12 +249,12 @@ public final class StatusLogger extends 
         
         private final int size;
 
-        public BoundedQueue(int size) {
+        public BoundedQueue(final int size) {
             this.size = size;
         }
 
         @Override
-        public boolean add(E object) {
+        public boolean add(final E object) {
             while (messages.size() > size) {
                 messages.poll();
             }

Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/EnglishEnums.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/EnglishEnums.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/EnglishEnums.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/EnglishEnums.java Mon Dec 10 19:36:06 2012
@@ -38,7 +38,7 @@ public class EnglishEnums {
      *            The enum name, case-insensitive. If null, returns {@code defaultValue}
      * @return an enum value or null if {@code name} is null
      */
-    public static <T extends Enum<T>> T valueOf(Class<T> enumType, String name) {
+    public static <T extends Enum<T>> T valueOf(final Class<T> enumType, final String name) {
         return valueOf(enumType, name, null);
     }
 
@@ -55,7 +55,7 @@ public class EnglishEnums {
      *            the enum value to return if {@code name} is null
      * @return an enum value or {@code defaultValue} if {@code name} is null
      */
-    public static <T extends Enum<T>> T valueOf(Class<T> enumType, String name, T defaultValue) {
+    public static <T extends Enum<T>> T valueOf(final Class<T> enumType, final String name, final T defaultValue) {
         return name == null ? defaultValue : Enum.valueOf(enumType, name.toUpperCase(Locale.ENGLISH));
     }
 

Modified: logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/PropsUtil.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/PropsUtil.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/PropsUtil.java (original)
+++ logging/log4j/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/util/PropsUtil.java Mon Dec 10 19:36:06 2012
@@ -24,43 +24,43 @@ import java.util.Properties;
  */
 public class PropsUtil {
 
-    private Properties props;
+    private final Properties props;
 
-    public PropsUtil(Properties props) {
+    public PropsUtil(final Properties props) {
         this.props = props;
     }
 
-    public PropsUtil(String propsLocn) {
+    public PropsUtil(final String propsLocn) {
         this.props = new Properties();
-        ClassLoader loader = findClassLoader();
-        InputStream in = loader.getResourceAsStream(propsLocn);
+        final ClassLoader loader = findClassLoader();
+        final InputStream in = loader.getResourceAsStream(propsLocn);
         if (null != in) {
             try {
                 this.props.load(in);
                 in.close();
-            } catch(java.io.IOException e) {
+            } catch(final java.io.IOException e) {
                 // ignored
             }
         }
     }
 
-    public String getStringProperty(String name) {
+    public String getStringProperty(final String name) {
         String prop = null;
         try {
             prop = System.getProperty(name);
-        } catch (SecurityException e) {
+        } catch (final SecurityException e) {
             // Ignore
         }
         return (prop == null) ? props.getProperty(name) : prop;
     }
 
-    public String getStringProperty(String name, String defaultValue) {
-        String prop = getStringProperty(name);
+    public String getStringProperty(final String name, final String defaultValue) {
+        final String prop = getStringProperty(name);
         return (prop == null) ? defaultValue : prop;
     }
 
-    public boolean getBooleanProperty(String name, boolean defaultValue) {
-        String prop = getStringProperty(name);
+    public boolean getBooleanProperty(final String name, final boolean defaultValue) {
+        final String prop = getStringProperty(name);
         return (prop == null) ? defaultValue : "true".equalsIgnoreCase(prop);
     }
 

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java Mon Dec 10 19:36:06 2012
@@ -323,7 +323,7 @@ public class AbstractLoggerTest extends 
     }
 
     @Override
-    protected void log(Marker marker, String fqcn, Level level, Message data, Throwable t) {
+    protected void log(final Marker marker, final String fqcn, final Level level, final Message data, final Throwable t) {
         assertTrue("Incorrect Level. Expected " + currentLevel + ", actual " + level, level.equals(currentLevel));
         if (marker == null) {
             if (currentEvent.markerName != null) {
@@ -367,27 +367,27 @@ public class AbstractLoggerTest extends 
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String data) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String data) {
         return isEnabled(level, marker, new SimpleMessage(data), null);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String data, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String data, final Throwable t) {
         return isEnabled(level, marker, new SimpleMessage(data), t);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String data, Object... p1) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String data, final Object... p1) {
         return isEnabled(level, marker, new ParameterizedMessage(data, p1), null);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, Object data, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final Object data, final Throwable t) {
         return isEnabled(level, marker, new ObjectMessage(data), t);
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, Message data, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final Message data, final Throwable t) {
         assertTrue("Incorrect Level. Expected " + currentLevel + ", actual " + level, level.equals(currentLevel));
         if (marker == null) {
             if (currentEvent.markerName != null) {
@@ -438,7 +438,7 @@ public class AbstractLoggerTest extends 
         Message data;
         Throwable t;
 
-        public LogEvent(String markerName, Message data, Throwable t) {
+        public LogEvent(final String markerName, final Message data, final Throwable t) {
             this.markerName = markerName;
             this.data = data;
             this.t = t;

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/EventLoggerTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/EventLoggerTest.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/EventLoggerTest.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/EventLoggerTest.java Mon Dec 10 19:36:06 2012
@@ -44,14 +44,14 @@ public class EventLoggerTest {
         ThreadContext.put("loginId", "JohnDoe");
         ThreadContext.put("ipAddress", "192.168.0.120");
         ThreadContext.put("locale", Locale.US.getDisplayName());
-        StructuredDataMessage msg = new StructuredDataMessage("Transfer@18060", "Transfer Complete", "Audit");
+        final StructuredDataMessage msg = new StructuredDataMessage("Transfer@18060", "Transfer Complete", "Audit");
         msg.put("ToAccount", "123456");
         msg.put("FromAccount", "123457");
         msg.put("Amount", "200.00");
         EventLogger.logEvent(msg);
         ThreadContext.clear();
         assertEquals(1, results.size());
-        String expected = " OFF Audit [Transfer@18060 Amount=\"200.00\" FromAccount=\"123457\" ToAccount=\"123456\"] Transfer Complete";
+        final String expected = " OFF Audit [Transfer@18060 Amount=\"200.00\" FromAccount=\"123457\" ToAccount=\"123456\"] Transfer Complete";
         assertTrue("Incorrect structured data: " + results.get(0) + ", expected: " ,results.get(0).startsWith(expected));
     }
 

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LevelTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LevelTest.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LevelTest.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LevelTest.java Mon Dec 10 19:36:06 2012
@@ -28,14 +28,14 @@ public class LevelTest {
 
     @Test
     public void testGoodLevels() {
-        Level level = Level.toLevel("INFO");
+        final Level level = Level.toLevel("INFO");
         assertNotNull(level);
         assertEquals(Level.INFO, level);
     }
 
     @Test
     public void testDefault() {
-        Level level = Level.toLevel("Information", Level.ERROR);
+        final Level level = Level.toLevel("Information", Level.ERROR);
         assertNotNull(level);
         assertEquals(Level.ERROR, level);
     }

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LoggerTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LoggerTest.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LoggerTest.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/LoggerTest.java Mon Dec 10 19:36:06 2012
@@ -61,7 +61,7 @@ public class LoggerTest {
     public void catching() {
         try {
             throw new NullPointerException();
-        } catch (Exception e) {
+        } catch (final Exception e) {
             logger.catching(e);
             assertEquals(1, results.size());
             assertTrue("Incorrect Catching",
@@ -100,7 +100,7 @@ public class LoggerTest {
 
     @Test
     public void getLoggerByClass() {
-        Logger classLogger = LogManager.getLogger(LoggerTest.class);
+        final Logger classLogger = LogManager.getLogger(LoggerTest.class);
         assertNotNull(classLogger);
     }
 
@@ -109,7 +109,7 @@ public class LoggerTest {
         // The TestLogger logger was already created in an instance variable for this class.
         // The message factory is only used when the logger is created.
         final ParameterizedMessageFactory messageFactory = new ParameterizedMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger(TestParameterizedMessageFactory.class,
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger(TestParameterizedMessageFactory.class,
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
@@ -123,7 +123,7 @@ public class LoggerTest {
         // The TestLogger logger was already created in an instance variable for this class.
         // The message factory is only used when the logger is created.
         final ParameterizedMessageFactory messageFactory = new ParameterizedMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger(new TestParameterizedMessageFactory(),
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger(new TestParameterizedMessageFactory(),
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
@@ -137,7 +137,7 @@ public class LoggerTest {
         // The TestLogger logger was already created in an instance variable for this class.
         // The message factory is only used when the logger is created.
         final StringFormatterMessageFactory messageFactory = new StringFormatterMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger(TestStringFormatterMessageFactory.class,
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger(TestStringFormatterMessageFactory.class,
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
@@ -151,7 +151,7 @@ public class LoggerTest {
         // The TestLogger logger was already created in an instance variable for this class.
         // The message factory is only used when the logger is created.
         final StringFormatterMessageFactory messageFactory = new StringFormatterMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger(new TestStringFormatterMessageFactory(),
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger(new TestStringFormatterMessageFactory(),
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
@@ -163,7 +163,7 @@ public class LoggerTest {
     @Test
     public void getLogger_String_ParameterizedMessageFactory() {
         final ParameterizedMessageFactory messageFactory = new ParameterizedMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger("getLogger_String_ParameterizedMessageFactory",
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger("getLogger_String_ParameterizedMessageFactory",
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
@@ -175,7 +175,7 @@ public class LoggerTest {
     @Test
     public void getLogger_String_StringFormatterMessageFactory() {
         final StringFormatterMessageFactory messageFactory = new StringFormatterMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger("getLogger_String_StringFormatterMessageFactory",
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger("getLogger_String_StringFormatterMessageFactory",
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
@@ -187,11 +187,11 @@ public class LoggerTest {
     @Test
     public void getLogger_String_MessageFactoryMismatch() {
         final StringFormatterMessageFactory messageFactory = new StringFormatterMessageFactory();
-        TestLogger testLogger = (TestLogger) LogManager.getLogger("getLogger_String_MessageFactoryMismatch",
+        final TestLogger testLogger = (TestLogger) LogManager.getLogger("getLogger_String_MessageFactoryMismatch",
                 messageFactory);
         assertNotNull(testLogger);
         assertEquals(messageFactory, testLogger.getMessageFactory());
-        TestLogger testLogger2 = (TestLogger) LogManager.getLogger("getLogger_String_MessageFactoryMismatch",
+        final TestLogger testLogger2 = (TestLogger) LogManager.getLogger("getLogger_String_MessageFactoryMismatch",
                 new ParameterizedMessageFactory());
         //TODO: How to test?
         //This test context always creates new loggers, other test context impls I tried fail other tests.
@@ -219,7 +219,7 @@ public class LoggerTest {
 
     @Test
     public void getLoggerByObject() {
-        Logger classLogger = LogManager.getLogger(this);
+        final Logger classLogger = LogManager.getLogger(this);
         assertNotNull(classLogger);
         assertEquals(classLogger, LogManager.getLogger(LoggerTest.class));
     }
@@ -294,7 +294,7 @@ public class LoggerTest {
         ThreadContext.put("loginId", "JohnDoe");
         ThreadContext.put("ipAddress", "192.168.0.120");
         ThreadContext.put("locale", Locale.US.getDisplayName());
-        StructuredDataMessage msg = new StructuredDataMessage("Audit@18060", "Transfer Complete", "Transfer");
+        final StructuredDataMessage msg = new StructuredDataMessage("Audit@18060", "Transfer Complete", "Transfer");
         msg.put("ToAccount", "123456");
         msg.put("FromAccount", "123457");
         msg.put("Amount", "200.00");

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/NoopThreadContextTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/NoopThreadContextTest.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/NoopThreadContextTest.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/NoopThreadContextTest.java Mon Dec 10 19:36:06 2012
@@ -42,7 +42,7 @@ public class NoopThreadContextTest {
     @Test
     public void testNoop() {
         ThreadContext.put("Test", "Test");
-        String value = ThreadContext.get("Test");
+        final String value = ThreadContext.get("Test");
         assertNull("value was saved", value);
     }
 

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLogger.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLogger.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLogger.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLogger.java Mon Dec 10 19:36:06 2012
@@ -35,34 +35,34 @@ public class TestLogger extends Abstract
         super();
     }
 
-    public TestLogger(String name, MessageFactory messageFactory) {
+    public TestLogger(final String name, final MessageFactory messageFactory) {
         super(name, messageFactory);
     }
 
-    public TestLogger(String name) {
+    public TestLogger(final String name) {
         super(name);
     }
 
-    private List<String> list = new ArrayList<String>();
+    private final List<String> list = new ArrayList<String>();
 
     public List<String> getEntries() {
         return list;
     }
 
     @Override
-    public void log(Marker marker, String fqcn, Level level, Message msg, Throwable throwable) {
-        StringBuilder sb = new StringBuilder();
+    public void log(final Marker marker, final String fqcn, final Level level, final Message msg, final Throwable throwable) {
+        final StringBuilder sb = new StringBuilder();
         sb.append(" ");
         sb.append(level.toString());
         sb.append(" ");
         sb.append(msg.getFormattedMessage());
-        Map<String, String> mdc = ThreadContext.getContext();
+        final Map<String, String> mdc = ThreadContext.getContext();
         if (mdc.size() > 0) {
             sb.append(" ");
             sb.append(mdc.toString());
             sb.append(" ");
         }
-        Object[] params = msg.getParameters();
+        final Object[] params = msg.getParameters();
         Throwable t;
         if (throwable == null && params != null && params[params.length -1] instanceof Throwable ) {
             t = (Throwable) params[params.length - 1];
@@ -71,7 +71,7 @@ public class TestLogger extends Abstract
         }
         if (t != null) {
             sb.append(" ");
-            ByteArrayOutputStream baos = new ByteArrayOutputStream();
+            final ByteArrayOutputStream baos = new ByteArrayOutputStream();
             t.printStackTrace(new PrintStream(baos));
             sb.append(baos.toString());
         }
@@ -80,28 +80,28 @@ public class TestLogger extends Abstract
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String msg) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String msg) {
         return true;
     }
 
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String msg, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String msg, final Throwable t) {
         return true;
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, String msg, Object... p1) {
+    protected boolean isEnabled(final Level level, final Marker marker, final String msg, final Object... p1) {
         return true;
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, Object msg, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final Object msg, final Throwable t) {
         return true;
     }
 
     @Override
-    protected boolean isEnabled(Level level, Marker marker, Message msg, Throwable t) {
+    protected boolean isEnabled(final Level level, final Marker marker, final Message msg, final Throwable t) {
         return true;
     }
 }

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContext.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContext.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContext.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContext.java Mon Dec 10 19:36:06 2012
@@ -23,17 +23,17 @@ import org.apache.logging.log4j.spi.Logg
  *
  */
 public class TestLoggerContext implements LoggerContext {
-    private Logger logger = new TestLogger();
+    private final Logger logger = new TestLogger();
 
-    public Logger getLogger(String name) {
+    public Logger getLogger(final String name) {
         return logger;
     }
 
-    public Logger getLogger(String name, MessageFactory messageFactory) {
+    public Logger getLogger(final String name, final MessageFactory messageFactory) {
         return new TestLogger(name, messageFactory);
     }
 
-    public boolean hasLogger(String name) {
+    public boolean hasLogger(final String name) {
         return false;
     }
 

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContextFactory.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContextFactory.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContextFactory.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/TestLoggerContextFactory.java Mon Dec 10 19:36:06 2012
@@ -26,7 +26,7 @@ public class TestLoggerContextFactory im
 
     private static LoggerContext context = new TestLoggerContext();
 
-    public LoggerContext getContext(String fqcn, ClassLoader loader, boolean currentContext) {
+    public LoggerContext getContext(final String fqcn, final ClassLoader loader, final boolean currentContext) {
         return context;
     }
 }

Modified: logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/Timer.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/Timer.java?rev=1419697&r1=1419696&r2=1419697&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/Timer.java (original)
+++ logging/log4j/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/Timer.java Mon Dec 10 19:36:06 2012
@@ -26,11 +26,11 @@ public class Timer implements Serializab
 {
     private static final long serialVersionUID = 9175191792439630013L;
     
-    private String m_name;              // The timer's name
+    private final String m_name;              // The timer's name
     private String m_status;            // The timer's status
     private long m_startTime;           // The start time
     private long m_elapsedTime;         // The elapsed time
-    private int m_iterations;
+    private final int m_iterations;
     private static long NANO_PER_SECOND = 1000000000L;
     private static long NANO_PER_MINUTE = NANO_PER_SECOND * 60;
     private static long NANO_PER_HOUR = NANO_PER_MINUTE * 60;
@@ -40,7 +40,7 @@ public class Timer implements Serializab
      * Constructor.
      * @param name the timer name.
      */
-    public Timer(String name)
+    public Timer(final String name)
     {
         this(name, 0);
     }
@@ -50,7 +50,7 @@ public class Timer implements Serializab
      *
      * @param name the timer name.
      */
-    public Timer(String name, int iterations)
+    public Timer(final String name, final int iterations)
     {
         m_name = name;
         m_startTime = 0;
@@ -142,7 +142,7 @@ public class Timer implements Serializab
     @Override
     public String toString()
     {
-        StringBuilder result = new StringBuilder("Timer ").append(m_name);
+        final StringBuilder result = new StringBuilder("Timer ").append(m_name);
         if (m_status.equals("Start"))
         {
             result.append(" started");
@@ -230,7 +230,7 @@ public class Timer implements Serializab
     }
 
     @Override
-    public boolean equals(Object o) {
+    public boolean equals(final Object o) {
         if (this == o) {
             return true;
         }



Mime
View raw message