Return-Path: X-Original-To: apmail-logging-commits-archive@minotaur.apache.org Delivered-To: apmail-logging-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F591D3A2 for ; Sat, 3 Nov 2012 02:58:02 +0000 (UTC) Received: (qmail 93296 invoked by uid 500); 3 Nov 2012 02:58:02 -0000 Delivered-To: apmail-logging-commits-archive@logging.apache.org Received: (qmail 93269 invoked by uid 500); 3 Nov 2012 02:58:02 -0000 Mailing-List: contact commits-help@logging.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@logging.apache.org Delivered-To: mailing list commits@logging.apache.org Received: (qmail 93262 invoked by uid 99); 3 Nov 2012 02:58:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Nov 2012 02:58:02 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Nov 2012 02:58:00 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 4575F238896F; Sat, 3 Nov 2012 02:57:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1405271 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java Date: Sat, 03 Nov 2012 02:57:39 -0000 To: commits@logging.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121103025739.4575F238896F@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ggregory Date: Sat Nov 3 02:57:38 2012 New Revision: 1405271 URL: http://svn.apache.org/viewvc?rev=1405271&view=rev Log: Make some ivars final. Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java?rev=1405271&r1=1405270&r2=1405271&view=diff ============================================================================== --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java (original) +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java Sat Nov 3 02:57:38 2012 @@ -38,27 +38,29 @@ public final class ExtendedThrowablePatt private static final String FILTERS = "filters("; - private List packages; + private final List packages; /** * Private constructor. * * @param options options, may be null. */ - private ExtendedThrowablePatternConverter(final String[] options) { + private ExtendedThrowablePatternConverter(final String[] options) { super("ExtendedThrowable", "throwable", options); + List tempPackages = null; if (options != null && options.length > 1) { if (options[1].startsWith(FILTERS) && options[1].endsWith(")")) { String filterStr = options[1].substring(FILTERS.length(), options[1].length() - 1); String[] array = filterStr.split(","); if (array.length > 0) { - packages = new ArrayList(array.length); + tempPackages = new ArrayList(array.length); for (String token : array) { - packages.add(token.trim()); + tempPackages.add(token.trim()); } } } } + packages = tempPackages; } /**