From commits-return-1566-apmail-logging-commits-archive=logging.apache.org@logging.apache.org Sat Nov 3 05:55:07 2012 Return-Path: X-Original-To: apmail-logging-commits-archive@minotaur.apache.org Delivered-To: apmail-logging-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C46CD740 for ; Sat, 3 Nov 2012 05:55:07 +0000 (UTC) Received: (qmail 70680 invoked by uid 500); 3 Nov 2012 05:55:06 -0000 Delivered-To: apmail-logging-commits-archive@logging.apache.org Received: (qmail 70646 invoked by uid 500); 3 Nov 2012 05:55:06 -0000 Mailing-List: contact commits-help@logging.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@logging.apache.org Delivered-To: mailing list commits@logging.apache.org Received: (qmail 70631 invoked by uid 99); 3 Nov 2012 05:55:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Nov 2012 05:55:06 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Nov 2012 05:55:04 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id AAA8F2388980; Sat, 3 Nov 2012 05:54:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1405282 - in /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core: Appender.java appender/AbstractAppender.java Date: Sat, 03 Nov 2012 05:54:44 -0000 To: commits@logging.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121103055444.AAA8F2388980@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ggregory Date: Sat Nov 3 05:54:43 2012 New Revision: 1405282 URL: http://svn.apache.org/viewvc?rev=1405282&view=rev Log: Use generics and fix compile warnings. Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/Appender.java logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/AbstractAppender.java Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/Appender.java URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/Appender.java?rev=1405282&r1=1405281&r2=1405282&view=diff ============================================================================== --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/Appender.java (original) +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/Appender.java Sat Nov 3 05:54:43 2012 @@ -16,10 +16,12 @@ */ package org.apache.logging.log4j.core; +import java.io.Serializable; + /** * @issue LOG4J2-36: Appender interface should be refactored */ -public interface Appender extends LifeCycle { +public interface Appender extends LifeCycle { /** * Log in Appender specific way. When appropriate, @@ -44,7 +46,7 @@ public interface Appender extends LifeCy * @return the Layout for the Appender or null if none is configured. * @issue LOG4J2-36 Refactor into Channel */ - Layout getLayout(); + Layout getLayout(); /** * If set to true any exceptions thrown by the Appender will be logged but not thrown. Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/AbstractAppender.java URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/AbstractAppender.java?rev=1405282&r1=1405281&r2=1405282&view=diff ============================================================================== --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/AbstractAppender.java (original) +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/appender/AbstractAppender.java Sat Nov 3 05:54:43 2012 @@ -16,6 +16,8 @@ */ package org.apache.logging.log4j.core.appender; +import java.io.Serializable; + import org.apache.logging.log4j.core.Appender; import org.apache.logging.log4j.core.ErrorHandler; import org.apache.logging.log4j.core.Filter; @@ -30,7 +32,7 @@ import org.apache.logging.log4j.Logger; * Abstract base class for Appenders. Although Appenders do not have to extend this class, doing so * will simplify their implementation. */ -public abstract class AbstractAppender extends Filterable implements Appender, LifeCycle { +public abstract class AbstractAppender extends Filterable implements Appender, LifeCycle { /** * Allow subclasses access to the status logger without creating another instance. */ @@ -41,7 +43,7 @@ public abstract class AbstractAppender e */ private boolean started = false; - private final Layout layout; + private final Layout layout; private final String name; @@ -55,7 +57,7 @@ public abstract class AbstractAppender e * @param filter The Filter to associate with the Appender. * @param layout The layout to use to format the event. */ - protected AbstractAppender(String name, Filter filter, Layout layout) { + protected AbstractAppender(String name, Filter filter, Layout layout) { this(name, filter, layout, true); } @@ -67,7 +69,7 @@ public abstract class AbstractAppender e * @param handleException If true, exceptions will be logged and suppressed. If false errors will be * logged and then passed to the application. */ - protected AbstractAppender(String name, Filter filter, Layout layout, boolean handleException) { + protected AbstractAppender(String name, Filter filter, Layout layout, boolean handleException) { super(filter); this.name = name; this.layout = layout; @@ -116,7 +118,7 @@ public abstract class AbstractAppender e * Returns the Layout for the appender. * @return The Layout used to format the event. */ - public Layout getLayout() { + public Layout getLayout() { return layout; }