From commits-return-1344-apmail-logging-commits-archive=logging.apache.org@logging.apache.org Tue Oct 9 19:55:46 2012 Return-Path: X-Original-To: apmail-logging-commits-archive@minotaur.apache.org Delivered-To: apmail-logging-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29159D030 for ; Tue, 9 Oct 2012 19:55:46 +0000 (UTC) Received: (qmail 79758 invoked by uid 500); 9 Oct 2012 19:55:45 -0000 Delivered-To: apmail-logging-commits-archive@logging.apache.org Received: (qmail 79731 invoked by uid 500); 9 Oct 2012 19:55:45 -0000 Mailing-List: contact commits-help@logging.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@logging.apache.org Delivered-To: mailing list commits@logging.apache.org Received: (qmail 79722 invoked by uid 99); 9 Oct 2012 19:55:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2012 19:55:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2012 19:55:43 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 86A2F2388A29; Tue, 9 Oct 2012 19:54:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1396250 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/JMSTopicManager.java Date: Tue, 09 Oct 2012 19:54:59 -0000 To: commits@logging.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121009195459.86A2F2388A29@eris.apache.org> Author: ggregory Date: Tue Oct 9 19:54:58 2012 New Revision: 1396250 URL: http://svn.apache.org/viewvc?rev=1396250&view=rev Log: Make ivars and svar final. Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/JMSTopicManager.java Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/JMSTopicManager.java URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/JMSTopicManager.java?rev=1396250&r1=1396249&r2=1396250&view=diff ============================================================================== --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/JMSTopicManager.java (original) +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/net/JMSTopicManager.java Tue Oct 9 19:54:58 2012 @@ -34,11 +34,11 @@ import java.io.Serializable; */ public class JMSTopicManager extends AbstractJMSManager { - private static ManagerFactory factory = new JMSTopicManagerFactory(); + private static final ManagerFactory factory = new JMSTopicManagerFactory(); - private TopicConnection topicConnection; - private TopicSession topicSession; - private TopicPublisher topicPublisher; + private final TopicConnection topicConnection; + private final TopicSession topicSession; + private final TopicPublisher topicPublisher; /** * Constructor.