livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-livy] wypoon commented on issue #284: [LIVY-752] Fix implementation of limits on connections.
Date Thu, 05 Mar 2020 22:02:22 GMT
wypoon commented on issue #284: [LIVY-752] Fix implementation of limits on connections.
URL: https://github.com/apache/incubator-livy/pull/284#issuecomment-595469915
 
 
   > I think the helper `withinLimits()` is no longer used.
   > 
   Thanks for pointing that out. I'll remove it.
   
   > without testing for concurrency, could you at least add a basic unit test that the
limits are enforced, say on `anyViolations()`? (given that the logic was entirely backwards
before, a unit test seems like it would help here.)
   
   Yes, it would be helpful to have a basic unit test for that.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message