livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-livy] bersprockets commented on a change in pull request #284: [LIVY-752] Fix implementation of limits on connections.
Date Thu, 05 Mar 2020 21:30:31 GMT
bersprockets commented on a change in pull request #284: [LIVY-752] Fix implementation of limits
on connections.
URL: https://github.com/apache/incubator-livy/pull/284#discussion_r388577208
 
 

 ##########
 File path: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyThriftSessionManager.scala
 ##########
 @@ -455,17 +457,45 @@ class LivyThriftSessionManager(val server: LivyThriftServer, val livyConf:
LivyC
     }
   }
 
-  // Taken from Hive
   private def anyViolations(username: String, ipAddress: String): Option[String] = {
 
 Review comment:
   This now has a funny name, because it's responsible for incrementing (and possibly decrementing)
counts as part of testing if there are any violations. So it has that side effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message