From reviews-return-1830-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org Wed Sep 4 07:40:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D6FC71804BB for ; Wed, 4 Sep 2019 09:40:09 +0200 (CEST) Received: (qmail 8392 invoked by uid 500); 4 Sep 2019 11:59:31 -0000 Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@livy.incubator.apache.org Delivered-To: mailing list reviews@livy.incubator.apache.org Received: (qmail 8379 invoked by uid 99); 4 Sep 2019 11:59:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Sep 2019 11:59:31 +0000 From: GitBox To: reviews@livy.apache.org Subject: [GitHub] [incubator-livy] jerryshao commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer Message-ID: <156758280927.9690.4903448349809055552.gitbox@gitbox.apache.org> Date: Wed, 04 Sep 2019 07:40:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jerryshao commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r320614092 ########## File path: pom.xml ########## @@ -1009,6 +1007,20 @@ + Review comment: If there's no timeout currently, I would suggest to not change here and in travis file, let's do it in a separate PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services