livy-reviews mailing list archives

yantzu opened a new pull request #223: [LIVY-658]RSCDriver should catch exception if cancel
job failed during shutdown
URL: https://github.com/apache/incubator-livy/pull/223
 
 
   ## What changes were proposed in this pull request?
   
   Currently, if startup meet exception, exception will trigger spark to shutdown, then trigger
cancel job, but cancel job will throw another exception due to spark is not initialized. The
new exception will swallow the old exception.
   
   Before changes:
   ![cancel job exception](https://user-images.githubusercontent.com/7855100/64118287-f0961900-cdc9-11e9-9b72-d051fb4bdbdf.jpg)
   
   After changes:
   ![cancel job exception after fix](https://user-images.githubusercontent.com/7855100/64118295-f4c23680-cdc9-11e9-9a2d-38efa0770a99.jpg)
   
   ## How was this patch tested?
   
   Tested manually.
   
   Please review https://livy.incubator.apache.org/community/ before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services