livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjoernlohrmann <...@git.apache.org>
Subject [GitHub] incubator-livy pull request #128: Use setJobGroup/cancelJobGroup to cancel b...
Date Tue, 13 Nov 2018 22:21:27 GMT
GitHub user bjoernlohrmann opened a pull request:

    https://github.com/apache/incubator-livy/pull/128

    Use setJobGroup/cancelJobGroup to cancel bypass jobs

    ## What changes were proposed in this pull request?
    
    This PR fixes [LIVY-533](https://issues.apache.org/jira/browse/LIVY-533).
    
    The proposed fix invokes setJobGroup() in the worker thread before calling job code, and
cancelJobGroup() when another thread tries to cancel job execution. synchronized blocks are
employed to guard against race conditions.
    
    Also, this PR removes some unused code from the JobWrapper class.
    
    ## How was this patch tested?
    
    Manual as well as Livy test suite. No new tests were added.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjoernlohrmann/incubator-livy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-livy/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit 989225990ed139d2f5ed35e89e4dcbcead96b4dc
Author: Bjoern Lohrmann <5310706+bjoernlohrmann@...>
Date:   2018-11-13T09:37:30Z

    Use setJobGroup/cancelJobGroup to cancel bypass jobs

----


---

Mime
View raw message