livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec
Date Thu, 29 Nov 2018 10:12:37 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/117#discussion_r237423913
  
    --- Diff: server/src/main/scala/org/apache/livy/LivyConf.scala ---
    @@ -98,10 +98,78 @@ object LivyConf {
       val LAUNCH_KERBEROS_REFRESH_INTERVAL = Entry("livy.server.launch.kerberos.refresh-interval",
"1h")
       val KINIT_FAIL_THRESHOLD = Entry("livy.server.launch.kerberos.kinit-fail-threshold",
5)
     
    +  // Thrift configurations
       val THRIFT_SERVER_ENABLED = Entry("livy.server.thrift.enabled", false)
       val THRIFT_INCR_COLLECT_ENABLED = Entry("livy.server.thrift.incrementalCollect", false)
       val THRIFT_SESSION_CREATION_TIMEOUT = Entry("livy.server.thrift.session.creationTimeout",
"10m")
       val THRIFT_SERVER_JAR_LOCATION = Entry("livy.server.thrift.jarLocation", null)
    +  // The following configs are the same present in Hive
    +  val THRIFT_RESULTSET_DEFAULT_FETCH_SIZE =
    +    Entry("livy.server.thrift.resultset.default.fetch.size", 1000)
    +  val THRIFT_SPNEGO_PRINCIPAL = Entry("livy.server.thrift.authentication.spnego.principal",
"")
    --- End diff --
    
    yes, I thought about that too but I was not sure, so I kept this. Let me remove it and
replace it with `AUTH_KERBEROS_PRINCIPAL` then. Thanks.


---

Mime
View raw message