livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec
Date Thu, 29 Nov 2018 00:57:16 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/117#discussion_r237318814
  
    --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftHttpServlet.scala
---
    @@ -0,0 +1,500 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.livy.thriftserver.cli
    +
    +import java.io.IOException
    +import java.security.{PrivilegedExceptionAction, SecureRandom}
    +import javax.servlet.ServletException
    +import javax.servlet.http.{Cookie, HttpServletRequest, HttpServletResponse}
    +import javax.ws.rs.core.NewCookie
    +
    +import scala.collection.JavaConverters._
    +
    +import org.apache.commons.codec.binary.{Base64, StringUtils}
    +import org.apache.hadoop.security.UserGroupInformation
    +import org.apache.hadoop.security.authentication.util.KerberosName
    +import org.apache.hive.service.CookieSigner
    +import org.apache.hive.service.auth.{HiveAuthConstants, HttpAuthenticationException,
HttpAuthUtils}
    +import org.apache.hive.service.auth.HiveAuthConstants.AuthTypes
    +import org.apache.hive.service.cli.HiveSQLException
    +import org.apache.thrift.TProcessor
    +import org.apache.thrift.protocol.TProtocolFactory
    +import org.apache.thrift.server.TServlet
    +import org.ietf.jgss.{GSSContext, GSSCredential, GSSException, GSSManager, Oid}
    +
    +import org.apache.livy.{LivyConf, Logging}
    +import org.apache.livy.thriftserver.SessionInfo
    +import org.apache.livy.thriftserver.auth.{AuthenticationProvider, AuthFactory}
    +
    +class ThriftHttpServlet(
    --- End diff --
    
    Comment about where this comes from? (Even if it's similar to the other classes above.)


---

Mime
View raw message