livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] incubator-livy issue #129: [LIVY-535] Fix non-atomic session creation
Date Wed, 28 Nov 2018 21:54:35 GMT
Github user vanzin commented on the issue:

    https://github.com/apache/incubator-livy/pull/129
  
    The code shouldn't be spending that much time in the synchronized block. It does do quite
a lot of things, including spawning a child process, but it doesn't wait for that process
to finish or anything like that. So it should be reasonably ok.
    
    Otherwise this fix would be way more complicated. The accounting for how many things are
starting is all over the place. If you want to spend time fixing that instead...


---

Mime
View raw message