libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Eis-D-Z commented on pull request #1469: Pricing aws
Date Fri, 03 Jul 2020 13:42:08 GMT

Eis-D-Z commented on pull request #1469:
URL: https://github.com/apache/libcloud/pull/1469#issuecomment-653554679


   @Kami I believe that the first option you proposed is the best for the moment. That is
adding a region argument like `def get_size_price(driver_type, driver_name, size_id, region=None)`
and later in the code check if a region was given and get the price based on the region  `price
= float(pricing[size_id][region])`, and if region is None then as it was until now.
   
   In our day to day, cost and pricing is a hot demand thus I kinda foresee that this first
step in this direction has its good side, I expect that eventually an all around and standard
format will be reached, until then I would treat this just as a first step in that direction.

   
   If you can confirm that the first option you proposed is acceptable I will proceed with
the necessary changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message