libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on pull request #1469: Pricing aws
Date Thu, 02 Jul 2020 14:56:57 GMT

Kami commented on pull request #1469:
URL: https://github.com/apache/libcloud/pull/1469#issuecomment-653055900


   @Eis-D-Z ^ what's your take on this?
   
   I'm worried because ``get_size_price`` function expects pricing data in pricing.json file
to be in a specific format. And changes in this PR brake promise about that format (aka they
change the format, but for EC2 only).
   
   One option is to add support for region argument to that function or perhaps add new ``get_size_price_for_region``
function and make sure we support both pricing formats.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message