libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on pull request #1469: Pricing aws
Date Thu, 02 Jul 2020 14:48:53 GMT

Kami commented on pull request #1469:
URL: https://github.com/apache/libcloud/pull/1469#issuecomment-653051232


   I fixed the sorting locally, but there is another error in how we retrieve pricing data
inside the driver code.
   
   ```bash
   Traceback (most recent call last):
     File "/home/kami/w/libcloud/libcloud/libcloud/test/compute/__init__.py", line 32, in
test_list_sizes_response
       sizes = self.driver.list_sizes()
     File "/home/kami/w/libcloud/libcloud/libcloud/compute/drivers/ec2.py", line 6210, in
list_sizes
       size_id=instance_type)
     File "/home/kami/w/libcloud/libcloud/libcloud/pricing.py", line 150, in get_size_price
       price = float(pricing[size_id])
   TypeError: float() argument must be a string or a number, not 'dict'
   ```
   
   I'll also push a fix for that, but I'm also slightly worried about this change - some other
driver classes also rely on the base EC2 driver and we need to be sure this PR doesn't introduce
inadvertent regressions and brakes other drivers or similar.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message