libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Eis-D-Z opened a new pull request #1469: Pricing aws
Date Wed, 17 Jun 2020 11:52:23 GMT

Eis-D-Z opened a new pull request #1469:
URL: https://github.com/apache/libcloud/pull/1469


   ## Changes Title 
   EC2 pricing update
   
   ### Description
   
   The main url from which prices were scraped is deprecated, this introduces a new url and
a  new location (Stockholm). The format in which the prices are to be saved in the pricing.json
file is also changed, now it is ec2_linux (or ec2_windows) --> size --> region -->
price. This was done for convenience, some regions do not have some sizes and in other clouds
the price might default to another region, this way it is easier to introduce a default, also
it is easier to add prices for different premium images in the future like RHEL and SLES.
For the moment only windows prices are being scraped besides the linux ones (free images),
even though for libcloud's current needs windows prices are not necessary. The driver is also
changed so prices can be fetched correctly. This request does not include the resulting constants.py
and pricing.json after the scripts are run. If it should please let me know.
   
   ### Status
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [x] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message