libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] avirshup opened a new pull request #1453: Implement s3 get_object_cdn_url using pre-signed urls
Date Fri, 01 May 2020 06:37:04 GMT

avirshup opened a new pull request #1453:
URL: https://github.com/apache/libcloud/pull/1453


   ## Implement `get_object_cdn_url` for S3 using pre-signed urls
   
   ### Description
   
   Allows the s3 driver to generate [pre-signed URLs](https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-query-string-auth.html)
using the `get_object_cdn_url` method. Anyone in possession of these URLs can _read_ the object
until the URL expires. (As suggested in issue #1403)
   
   I've tried to follow the example of PR #1408 - which implements that Azure version of this
function - as much as possible.
   
   Note that, to prevent code duplication, I've used some internal functions from the `AWSRequestSignerAlgorithmV4`
object.
   
   Long-time user, first-time PR-opener - happy to make changes as needed.
   
   ### Status
   Ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [x] Documentation
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message