libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on pull request #1453: Implement s3 get_object_cdn_url using pre-signed urls
Date Sun, 03 May 2020 19:29:28 GMT

Kami commented on pull request #1453:
URL: https://github.com/apache/libcloud/pull/1453#issuecomment-623167298


   > many providers use the S3 driver. Because this is tied specifically to AWS's authentication
methods, I had to modify a few tests to make sure that this doesn't change behavior elsewhere.
   
   Yeah, IIRC, the class hierarchy is not the best, so some changes like that are not totally
straight forward (some of the existing functionality should be implemented on the AWS S3 driver
and not on the base S3 one from which other S3 compatible provider drivers inherit from).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message