libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1451: Add no cache and Optimize the Dockerfile format
Date Sun, 03 May 2020 14:56:16 GMT

Kami commented on a change in pull request #1451:
URL: https://github.com/apache/libcloud/pull/1451#discussion_r419114908



##########
File path: contrib/Dockerfile
##########
@@ -1,32 +1,34 @@
 FROM ubuntu:16.04
 
 RUN set -e && \
-  apt-get update && \
-  apt-get install -y \
-    software-properties-common \
-    wget \
-    ssh && \
-  add-apt-repository ppa:deadsnakes/ppa && \
-  apt-get update && \
-  apt-get -y install \
-    python2.7 \
-    python3.4 \
-    python3.5 \
-    python3.6 \
-    python-dev \
-    python2.7-dev \
-    python3.4-dev \
-    python3.5-dev \
-    python3.6-dev \
-    pypy \
-    python-pip
+    apt-get update && \
+    apt-get install -y \
+      software-properties-common \
+      wget \
+      ssh && \
+    add-apt-repository ppa:deadsnakes/ppa && \
+    apt-get update && \
+    apt-get -y install \
+      python2.7 \
+      python3.4 \
+      python3.5 \
+      python3.6 \
+      python-dev \
+      python2.7-dev \
+      python3.4-dev \
+      python3.5-dev \
+      python3.6-dev \
+      pypy \
+      python-pip
 
 RUN set -e && \
-  pip install tox \
-    mock \
-    lockfile \
-    coverage
+    pip install --no-cache-dir tox \
+      mock \
+      lockfile \
+      coverage
 
 COPY . /libcloud
+
 WORKDIR /libcloud
-CMD tox -e py2.7,pypypy,py3.4,py3.5,py3.6,lint
+
+CMD ["tox", "-e", "py2.7", "pypypy", "py3.4", "py3.5", "py3.6", "lint"]

Review comment:
       This actually won't work correctly, targets need to be passed to tox as a single argument.
   
   So either:
   
   ```
   tox -epy1,py2...
   ```
   
   Or:
   
   ```
   ["tox", "-e", "py1,py"]
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message