From notifications-return-16870-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Thu Feb 20 10:48:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D16A418065D for ; Thu, 20 Feb 2020 11:48:52 +0100 (CET) Received: (qmail 282 invoked by uid 500); 20 Feb 2020 10:48:52 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 273 invoked by uid 99); 20 Feb 2020 10:48:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2020 10:48:52 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] foospidy opened a new pull request #1432: Make id lower for consistent uuid generation Message-ID: Date: Thu, 20 Feb 2020 10:48:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit foospidy opened a new pull request #1432: Make id lower for consistent uuid generation URL: https://github.com/apache/libcloud/pull/1432 ## Make id lower for consistent uuid generation ### Description When a node is created, the resource groups name in the id string is lower case. In subsequent calls, like in list_nodes(), for some reason Azure returns the resource groups name in upper case. This results in a different uuid from when create_node is called. This also breaks wait_until_running(). Forcing lower case in _to_node() seems to resolve this issue. ### Status - done, ready for review ### Checklist - [x ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services