libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] foospidy opened a new pull request #1432: Make id lower for consistent uuid generation
Date Thu, 20 Feb 2020 10:48:52 GMT
foospidy opened a new pull request #1432: Make id lower for consistent uuid generation
URL: https://github.com/apache/libcloud/pull/1432
 
 
   ## Make id lower for consistent uuid generation
   
   ### Description
   
   When a node is created, the resource groups name in the id string is lower case. In subsequent
calls, like in list_nodes(), for some reason Azure returns the resource groups name in upper
case. This results in a different uuid from when create_node is called. This also breaks wait_until_running().
Forcing lower case in _to_node() seems to resolve this issue.
   
   ### Status
   
   - done, ready for review
   
   ### Checklist
   
   - [x ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message