From notifications-return-16732-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Tue Jan 14 15:40:08 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9B1F918061A for ; Tue, 14 Jan 2020 16:40:07 +0100 (CET) Received: (qmail 33634 invoked by uid 500); 14 Jan 2020 15:40:07 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 33625 invoked by uid 99); 14 Jan 2020 15:40:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jan 2020 15:40:07 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] c-w opened a new pull request #1410: Add type annotations to storage API Message-ID: Date: Tue, 14 Jan 2020 15:40:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit c-w opened a new pull request #1410: Add type annotations to storage API URL: https://github.com/apache/libcloud/pull/1410 ## Add type annotations to storage API ### Description As discussed in https://github.com/apache/libcloud/pull/1408#discussion_r366147905, this PR adds type annotations to the StorageDriver API. For now, mypy errors are ignored for the s3, google_storage and cloudfiles drivers since the use of inheritance on the connection classes is causing issues which will require a more thorough strategy to address. ### Status - done, ready for review ### Checklist - [x] Code linting ([build passed](https://travis-ci.org/CatalystCode/libcloud/builds/636950988)) - [x] Documentation (updated docstrings) - [x] Tests ([build passed](https://travis-ci.org/CatalystCode/libcloud/builds/636950988)) - [x] ICLA ([committer](https://people.apache.org/phonebook.html?uid=clewolff)) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services