From notifications-return-16809-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Wed Jan 29 13:11:40 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0680B180643 for ; Wed, 29 Jan 2020 14:11:39 +0100 (CET) Received: (qmail 94598 invoked by uid 500); 29 Jan 2020 13:11:39 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 94587 invoked by uid 99); 29 Jan 2020 13:11:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jan 2020 13:11:39 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] Kami commented on issue #1419: ec2 driver does not support strings for size and image parameters Message-ID: <158030349908.24778.9357764980614133024.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 29 Jan 2020 13:11:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kami commented on issue #1419: ec2 driver does not support strings for size and image parameters URL: https://github.com/apache/libcloud/issues/1419#issuecomment-579748574 Thanks for reporting this. This works as designed / intended. Base compute API declares those arguments to be of a type of NodeImage and NodeSize. If any of the drivers supports string notation, that's because they don't comply with the base compute API. In the past, we didn't have a good automated way to enforce compliance with the base API so some things like that have slipped through, but going forward, some of that will be easier with the MyPy support. In short, in scenarios like that, you need to instantiate ``NodeImage`` and ``NodeSize`` classes yourself manually (although some drivers may offer convenience extension methods for that). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services