From notifications-return-16717-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Tue Jan 14 04:28:40 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2977918064E for ; Tue, 14 Jan 2020 05:28:40 +0100 (CET) Received: (qmail 96519 invoked by uid 500); 14 Jan 2020 04:28:39 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 96510 invoked by uid 99); 14 Jan 2020 04:28:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jan 2020 04:28:39 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] Kami commented on a change in pull request #1408: Implement SAS URL generation for Azure Storage Message-ID: <157897611936.28552.948945072901595484.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 14 Jan 2020 04:28:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kami commented on a change in pull request #1408: Implement SAS URL generation for Azure Storage URL: https://github.com/apache/libcloud/pull/1408#discussion_r366147905 ########## File path: libcloud/storage/drivers/azure_blobs.py ########## @@ -489,6 +503,70 @@ def get_object(self, container_name, object_name): raise ObjectDoesNotExistError(value=None, driver=self, object_name=object_name) + def get_object_cdn_url(self, obj, + ex_expiry=AZURE_STORAGE_CDN_URL_EXPIRY_HOURS): Review comment: Going forward, we can also start adding type annotations for various method arguments in the drivers when we introduce new functionality. We now don't support Python 2.7 anymore, but perhaps we should still start with type annotations in the comments and move to putting them directly into the method signatures in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services