libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] dpeschman opened a new issue #1413: mypy issues as of 2.8.0
Date Fri, 17 Jan 2020 22:48:00 GMT
dpeschman opened a new issue #1413: mypy issues as of 2.8.0
URL: https://github.com/apache/libcloud/issues/1413
 
 
   ## Summary
   Just wanted to feed back to you all a couple issues we had running mypy on our custom drivers
after upgrading to libcloud 2.8.0.
   
   ## Detailed Information
   - The type of NodeDriver.type is Provider, but our custom drivers assign a string to this
field which cause a mypy error.  Perhaps it should be Union[Provider, str]? 
   - NodeSize, NodeLocation, and NodeImage have driver typed to be Type[NodeDriver] in their
constructors, but this does not match Node, StorageVolume, and others which have it typed
as NodeDriver.  We have subclasses of some of these and use self.driver as an instance of
a driver, just like the Node class, and not as a driver class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message