libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1414: Fix incorrect type annotations in the base compute API
Date Mon, 20 Jan 2020 06:46:00 GMT
Kami commented on a change in pull request #1414: Fix incorrect type annotations in the base
compute API
URL: https://github.com/apache/libcloud/pull/1414#discussion_r368389288
 
 

 ##########
 File path: libcloud/compute/base.py
 ##########
 @@ -822,7 +822,7 @@ class NodeDriver(BaseDriver):
     name = None  # type: str
     api_name = None  # type: str
     website = None  # type: str
-    type = None  # type: Provider
+    type = None  # type: Union[Provider,str]
 
 Review comment:
   NOTE: Ideally this would always be ``Provider`` enum, but a lot of the existing code uses
``str`` type so we still need to support it for backward compatibility reasons.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message