libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1408: Implement SAS URL generation for Azure Storage
Date Tue, 14 Jan 2020 04:28:39 GMT
Kami commented on a change in pull request #1408: Implement SAS URL generation for Azure Storage
URL: https://github.com/apache/libcloud/pull/1408#discussion_r366147905
 
 

 ##########
 File path: libcloud/storage/drivers/azure_blobs.py
 ##########
 @@ -489,6 +503,70 @@ def get_object(self, container_name, object_name):
         raise ObjectDoesNotExistError(value=None, driver=self,
                                       object_name=object_name)
 
+    def get_object_cdn_url(self, obj,
+                           ex_expiry=AZURE_STORAGE_CDN_URL_EXPIRY_HOURS):
 
 Review comment:
   Going forward, we can also start adding type annotations for various method arguments in
the drivers when we introduce new functionality.
   
   We now don't support Python 2.7 anymore, but perhaps we should still start with type annotations
in the comments and move to putting them directly into the method signatures in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message