From notifications-return-16567-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Tue Dec 24 18:54:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 07C3818065E for ; Tue, 24 Dec 2019 19:54:24 +0100 (CET) Received: (qmail 24427 invoked by uid 500); 24 Dec 2019 18:54:24 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 24418 invoked by uid 99); 24 Dec 2019 18:54:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Dec 2019 18:54:24 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] Kami commented on a change in pull request #1394: Add KubeVirt driver & tests Message-ID: <157721366432.3741.1464064056698748629.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 24 Dec 2019 18:54:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kami commented on a change in pull request #1394: Add KubeVirt driver & tests URL: https://github.com/apache/libcloud/pull/1394#discussion_r361213476 ########## File path: libcloud/http.py ########## @@ -194,20 +194,22 @@ def __init__(self, host, port, secure=None, **kwargs): http_proxy_url_env = os.environ.get(HTTP_PROXY_ENV_VARIABLE_NAME, https_proxy_url_env) - # Connection argument rgument has precedence over environment variables + # Connection argument has precedence over environment variables proxy_url = kwargs.pop('proxy_url', http_proxy_url_env) self._setup_verify() self._setup_ca_cert() LibcloudBaseConnection.__init__(self) + self.session.timeout = kwargs.pop('timeout', 60) Review comment: Does this change the default ``requests`` timeout behavior? If so, we should probably only set that attribute if ``timeout`` is explicitly specified (for backward compatibility reasons and to make sure it doesn't negatively affect long running and streaming connections)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services