libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1394: Add KubeVirt driver & tests
Date Tue, 24 Dec 2019 18:54:24 GMT
Kami commented on a change in pull request #1394: Add KubeVirt driver & tests
URL: https://github.com/apache/libcloud/pull/1394#discussion_r361213476
 
 

 ##########
 File path: libcloud/http.py
 ##########
 @@ -194,20 +194,22 @@ def __init__(self, host, port, secure=None, **kwargs):
         http_proxy_url_env = os.environ.get(HTTP_PROXY_ENV_VARIABLE_NAME,
                                             https_proxy_url_env)
 
-        # Connection argument rgument has precedence over environment variables
+        # Connection argument has precedence over environment variables
         proxy_url = kwargs.pop('proxy_url', http_proxy_url_env)
 
         self._setup_verify()
         self._setup_ca_cert()
 
         LibcloudBaseConnection.__init__(self)
 
+        self.session.timeout = kwargs.pop('timeout', 60)
 
 Review comment:
   Does this change the default ``requests`` timeout behavior?
   
   If so, we should probably only set that attribute if ``timeout`` is explicitly specified
(for backward compatibility reasons and to make sure it doesn't negatively affect long running
and streaming connections)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message