libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami edited a comment on issue #1387: GCENodeDriver's deploy_node() now accepts Deployments as well as all the parameters accepted by create_node()
Date Fri, 20 Dec 2019 21:53:50 GMT
Kami edited a comment on issue #1387: GCENodeDriver's deploy_node() now accepts Deployments
as well as all the parameters accepted by create_node()
URL: https://github.com/apache/libcloud/pull/1387#issuecomment-568099245
 
 
   After merging #1389 I tried to test this change, but it doesn't appears to be working,
it appears to be incomplete.
   
   For ``deploy_node()`` to work, driver needs to declare authentication type it supports
using ``features`` driver class variable (aka it won't work "magically" if driver doesn't
declare support for it and accepts and correctly handles ``auth`` argument).
   
   In addition to that, ``create_node()`` then needs to accept and use ``auth`` argument.
   
   So without those changes, deployment won't work. In short - the actual change will likely
end up being much more involved.
   
   ---
   
   EDIT: I'm looking into it, I believe it should be relatively simple to get it to work utilizing
metadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message