From notifications-return-16362-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Mon Nov 25 19:21:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B2BFD180607 for ; Mon, 25 Nov 2019 20:21:07 +0100 (CET) Received: (qmail 74944 invoked by uid 500); 25 Nov 2019 19:21:07 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 74935 invoked by uid 99); 25 Nov 2019 19:21:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Nov 2019 19:21:07 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] KYDronePilot commented on a change in pull request #1373: VCloud Driver Features/Bugfixes Message-ID: <157470966695.19101.12550561589324835461.gitbox@gitbox.apache.org> Date: Mon, 25 Nov 2019 19:21:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit KYDronePilot commented on a change in pull request #1373: VCloud Driver Features/Bugfixes URL: https://github.com/apache/libcloud/pull/1373#discussion_r350375017 ########## File path: libcloud/compute/drivers/vcloud.py ########## @@ -1911,15 +2088,19 @@ def _add_vm_disk(self, vapp_or_vm_id, vm_disk): ) self._wait_for_task_completion(res.object.get('href')) - def _change_vm_script(self, vapp_or_vm_id, vm_script): - if vm_script is None: + def _change_vm_script(self, vapp_or_vm_id, vm_script, vm_script_text=None): + if vm_script is None and vm_script_text is None: return + if vm_script_text is not None: + script = vm_script_text + else: + try: + script = open(vm_script).read() Review comment: Fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services