libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] zimventures opened a new pull request #1376: Label support for GCP volumes
Date Tue, 26 Nov 2019 22:13:11 GMT
zimventures opened a new pull request #1376: Label support for GCP volumes
URL: https://github.com/apache/libcloud/pull/1376
 
 
   ## GCP Volumes - now with labels! 
   There was no support in the GCP provider for querying/setting labels on volumes - this
adds that!
   
   ### Description
   In order to set the labels for a disk, the user is required to pass in the last labelFingerprint,
which must be fetched first. This is done when building the StorageVolume object from a query,
pull out the relevant fields (labels, labelFingerprint) and stuff them in the `extra` dictionary.
   
   In addition, a new method has been added, `ex_set_volume_labels` which sets the labels
for a given volume.
   
   For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
   section of our documentation.
   
   ### Status
   - work in progress
   
   ### Checklist (tick everything that applies)
   
   - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message