libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] KYDronePilot commented on a change in pull request #1373: VCloud Driver Features/Bugfixes
Date Mon, 25 Nov 2019 19:21:06 GMT
KYDronePilot commented on a change in pull request #1373: VCloud Driver Features/Bugfixes
URL: https://github.com/apache/libcloud/pull/1373#discussion_r350375017
 
 

 ##########
 File path: libcloud/compute/drivers/vcloud.py
 ##########
 @@ -1911,15 +2088,19 @@ def _add_vm_disk(self, vapp_or_vm_id, vm_disk):
             )
             self._wait_for_task_completion(res.object.get('href'))
 
-    def _change_vm_script(self, vapp_or_vm_id, vm_script):
-        if vm_script is None:
+    def _change_vm_script(self, vapp_or_vm_id, vm_script, vm_script_text=None):
+        if vm_script is None and vm_script_text is None:
             return
 
+        if vm_script_text is not None:
+            script = vm_script_text
+        else:
+            try:
+                script = open(vm_script).read()
 
 Review comment:
   Fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message