libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] d-mo opened a new pull request #1351: Fix list_sizes on Packet when using project API tokens
Date Wed, 02 Oct 2019 15:21:55 GMT
d-mo opened a new pull request #1351: Fix list_sizes on Packet when using project API tokens
URL: https://github.com/apache/libcloud/pull/1351
 
 
   ## Fix list_sizes on Packet when using project API tokens
   ### Description
   
   The `list_sizes` method of the Packet driver was invoking the `/plans` API endpoint, which
is only available when using personal API tokens. Project specific API tokens should invoke
`/project/<project_id>/plans` instead. This PR uses the latter endpoint when `project_id`
is set.
   
   ### Status
   
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message