From notifications-return-15954-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Thu Aug 1 11:44:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B3344180644 for ; Thu, 1 Aug 2019 13:44:31 +0200 (CEST) Received: (qmail 81712 invoked by uid 500); 1 Aug 2019 11:44:31 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 81703 invoked by uid 99); 1 Aug 2019 11:44:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2019 11:44:31 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] codecov-io commented on issue #1331: Add function to remove a security group from a node in OpenStack driver #1330 Message-ID: <156465987104.21711.7160862591327619578.gitbox@gitbox.apache.org> Date: Thu, 01 Aug 2019 11:44:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io commented on issue #1331: Add function to remove a security group from a node in OpenStack driver #1330 URL: https://github.com/apache/libcloud/pull/1331#issuecomment-517249133 # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=h1) Report > Merging [#1331](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/4d318a81decfac35e246714477e846ba51cad4ba?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `88.23%`. [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1331/graphs/tree.svg?width=650&token=PYoduksh69&height=150&src=pr)](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## trunk #1331 +/- ## ========================================== - Coverage 86.27% 86.27% -0.01% ========================================== Files 367 367 Lines 75301 75315 +14 Branches 6885 6886 +1 ========================================== + Hits 64967 64979 +12 - Misses 7559 7560 +1 - Partials 2775 2776 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1331/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `84.05% <100%> (+0.05%)` | :arrow_up: | | [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1331/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.67% <84.61%> (-0.09%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=footer). Last update [4d318a8...870119c](https://codecov.io/gh/apache/libcloud/pull/1331?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services