libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] biggosh commented on a change in pull request #1328: powerdns driver adapted to work with pdns 3 and 4
Date Sun, 04 Aug 2019 15:47:36 GMT
biggosh commented on a change in pull request #1328: powerdns driver adapted to work with pdns
3 and 4
URL: https://github.com/apache/libcloud/pull/1328#discussion_r310392860
 
 

 ##########
 File path: libcloud/dns/drivers/powerdns.py
 ##########
 @@ -368,7 +392,7 @@ def list_zones(self):
         response = self.connection.request(action=action, method='GET')
         return self._to_zones(response)
 
-    def update_record(self, record, name, type, data, extra=None):
+    def update_record(self, record, name, type, data, extra=None, disabled=False, comment=None):
 
 Review comment:
   The new push has been modified: disabled and comment has been added to extra parameter
already declared
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message