libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] c-w commented on a change in pull request #1325: Specify minimum requests version
Date Fri, 02 Aug 2019 22:22:52 GMT
c-w commented on a change in pull request #1325: Specify minimum requests version
URL: https://github.com/apache/libcloud/pull/1325#discussion_r310315068
 
 

 ##########
 File path: CHANGES.rst
 ##########
 @@ -33,6 +33,9 @@ General
   https://libcloud.readthedocs.io/en/latest/other/using-http-proxy.html
   (GITHUB-1314)
   [Jim Liu - @hldh214, Tomaz Muraus]
+- Specify the minimum required version of requests.
 
 Review comment:
   Note that setting the minimum requests version to `2.5.0` is not directly related to the
RHEL issue in https://github.com/apache/libcloud/issues/1322 (the root cause of that issue
is differences in the code of requests 2.6.0 shipped in RPM vs PyPI). However, the investigation
of that issue led me to discover that `requests<=2.4.0` crashes on the Azure Storage driver
which is what inspired this PR. I've made this more explicit in 5fe2332.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message