From notifications-return-15902-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Fri Jul 26 14:23:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8B130180695 for ; Fri, 26 Jul 2019 16:23:02 +0200 (CEST) Received: (qmail 7321 invoked by uid 500); 26 Jul 2019 14:22:07 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 7309 invoked by uid 99); 26 Jul 2019 14:22:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2019 14:22:07 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] Kami commented on a change in pull request #1324: Fix proxy url Message-ID: <156415092695.7899.11015371485745682558.gitbox@gitbox.apache.org> Date: Fri, 26 Jul 2019 14:22:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kami commented on a change in pull request #1324: Fix proxy url URL: https://github.com/apache/libcloud/pull/1324#discussion_r307765180 ########## File path: libcloud/http.py ########## @@ -102,7 +102,8 @@ def set_http_proxy(self, proxy_url): self.http_proxy_used = True self.session.proxies = { - self.proxy_scheme: proxy_url + 'http': proxy_url, Review comment: I tested it and it works fine with just a single attribute set, but it also shouldn't hurt to set both (http and https). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services