From notifications-return-15848-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Fri Jul 19 09:16:50 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 344DC180665 for ; Fri, 19 Jul 2019 11:16:50 +0200 (CEST) Received: (qmail 22439 invoked by uid 500); 19 Jul 2019 09:16:49 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 22430 invoked by uid 99); 19 Jul 2019 09:16:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jul 2019 09:16:49 +0000 From: GitBox To: notifications@libcloud.apache.org Subject: [GitHub] [libcloud] Kami commented on issue #1318: added azure_arm ex_delete_public_ip Message-ID: <156352780952.16230.3031319898769415857.gitbox@gitbox.apache.org> Date: Fri, 19 Jul 2019 09:16:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kami commented on issue #1318: added azure_arm ex_delete_public_ip URL: https://github.com/apache/libcloud/pull/1318#issuecomment-513157993 @redha1419 Thanks for the contribution. The change looks good to me, but can you please add a test case for it? You can find other example test cases in ``libcloud/test/compute/test_azure_arm.py`` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services