libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on issue #1323: Add Gandi LiveDNS driver
Date Sun, 28 Jul 2019 10:04:50 GMT
Kami commented on issue #1323: Add Gandi LiveDNS driver
URL: https://github.com/apache/libcloud/pull/1323#issuecomment-515749740
 
 
   Thanks for the contribution.
   
   Overall it looks like a great start. There are just some minor things which need to be
sorted out.
   
   As far as ``Record.data`` field goes - I checked and I see that not all of the drivers
follow base API which says ``Record.data`` field should be a string (that's not great since
it breaks some of the portability aspect, we probably missed some of that during code reviews).
   
   I still think it would be better to return multiple ``Record`` objects in such scenario,
to comply with the base API.
   
   Here is an example of how a similar scenario is handled in the AWS Route 53 driver - https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/route53.py#L447.
   
   I know that means more work in the driver, but that's kinda the whole idea behind the abstraction
- we should try to expose the same interface everywhere where possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message