libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1324: Fix proxy url
Date Fri, 26 Jul 2019 14:22:06 GMT
Kami commented on a change in pull request #1324: Fix proxy url
URL: https://github.com/apache/libcloud/pull/1324#discussion_r307765180
 
 

 ##########
 File path: libcloud/http.py
 ##########
 @@ -102,7 +102,8 @@ def set_http_proxy(self, proxy_url):
         self.http_proxy_used = True
 
         self.session.proxies = {
-            self.proxy_scheme: proxy_url
+            'http': proxy_url,
 
 Review comment:
   I tested it and it works fine with just a single attribute set, but it also shouldn't hurt
to set both (http and https).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message