libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1286: LIBCLOUD-1042 set instance group manager auto healing policies
Date Tue, 02 Jul 2019 16:45:36 GMT
Kami commented on a change in pull request #1286: LIBCLOUD-1042 set instance group manager
auto healing policies
URL: https://github.com/apache/libcloud/pull/1286#discussion_r299581131
 
 

 ##########
 File path: libcloud/compute/drivers/gce.py
 ##########
 @@ -1456,6 +1456,26 @@ def set_named_ports(self, named_ports):
         return self.driver.ex_instancegroup_set_named_ports(
             instancegroup=self.instance_group, named_ports=named_ports)
 
+    def set_autoHealingPolicies(self, healthcheck, initialdelaysec):
 
 Review comment:
   I just noticed some other methods also use this notation.
   
   It's not ideal, but for consistency reasons I'm fine with using names as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message